Add doc for tidb_executor_concurrency by niedhui · Pull Request #3975 · pingcap/docs-cn

niedhui · 2020-07-15T15:05:30Z

What is changed, added or deleted? (Required)

Add docs for the new system variable, tidb_executor_concurrency

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Other reference link(s): UCP: Control the concurrency of all types of executors in one session variable tidb#15428

Signed-off-by: niedhui <niedhui@gmail.com>

CLAassistant · 2020-07-15T15:05:36Z

All committers have signed the CLA.

SunRunAway · 2020-07-16T05:41:11Z

+
+对于从 5.0.0 之前的版本升级到 5.0.0 的系统， 如果用户对上述七个变量没有做过改动（即 `tidb_hash_join_concurrency` 值为5，其他值为4），则会迁移到使用 `tidb_executor_concurrency` 来统一管理并发度， 否则继续沿用之前的变量值对相应的算子做并发控制。
+
 ### tidb_index_lookup_concurrency


修改一下这些变量的默认值，并且标明废弃吧。

SunRunAway · 2020-07-16T05:42:26Z

+
+默认值：5
+
+这个变量用来设置 index lookup，index lookup join，hash join，hash aggregation，window，projection 算子的并发度。


Suggested change

这个变量用来设置 index lookup，index lookup join，hash join，hash aggregation，window，projection 算子的并发度。

这个变量用来统一设置各个 SQL 算子的并发度。

包括：

- index lookup

- index lookup join

- hash join

- hash aggregation

- window

- projection

SunRunAway · 2020-07-16T05:43:45Z

+`tidb_executor_concurrency` 主要整合了之前的 `tidb_index_lookup_concurrency`，`tidb_index_lookup_join_concurrency`，`tidb_hash_join_concurrency`，`tidb_hashagg_partial_concurrency`，`tidb_hashagg_final_concurrency`，`tidb_projection_concurrency` 及 `tidb_window_concurrency` 这七个系统变量，方便管理。
+
+用户仍可以对上述七个系统变量做单独修改（会有废弃警告），修改只影响单个算子，后续对 `tidb_executor_concurrency` 的修改也不会影响该算子。可以通过将其值设置为`-1`，还原成通过 `tidb_executor_concurrency` 来管理该算子的并发度。


在这七个变量的地方也放上兼容性说明吧。

TomShawn · 2020-07-16T05:59:37Z

+
+用户仍可以对上述七个系统变量做单独修改（会有废弃警告），修改只影响单个算子，后续对 `tidb_executor_concurrency` 的修改也不会影响该算子。可以通过将其值设置为`-1`，还原成通过 `tidb_executor_concurrency` 来管理该算子的并发度。
+
+对于从 5.0.0 之前的版本升级到 5.0.0 的系统， 如果用户对上述七个变量没有做过改动（即 `tidb_hash_join_concurrency` 值为5，其他值为4），则会迁移到使用 `tidb_executor_concurrency` 来统一管理并发度， 否则继续沿用之前的变量值对相应的算子做并发控制。


现在最新版是 4.0.2 吧，接下来是 4.0.3。升级到 5.0.0 的系统 的表述会不会太早？

这个不会cherry pick 就是针对5.0的。

TomShawn · 2020-07-16T06:38:57Z


 这个变量用来设置 index lookup 操作的 batch 大小，AP 类应用适合较大的值，TP 类应用适合较小的值。

+### tidb_executor_concurrency <span class="version-mark">从 v5.0 版本开始引入</span>


@scsldb 现在 dev 文档中是否可以采用 v5.0 版本的表述呢？

Signed-off-by: niedhui <niedhui@gmail.com>

TomShawn · 2020-07-16T06:45:03Z


 这个变量用来设置 index lookup 操作的并发度，AP 类应用适合较大的值，TP 类应用适合较小的值。

+注意：从 5.0.0 版本开始，该变量已被废弃，请使用 [tidb_executor_concurrency](/tidb-specific-system-variables.md#tidb_executor_concurrency) 进行设置。


@SunRunAway

目前 v5.0 连 beta 都没发，已被废弃要不要换成将被废弃。

请采用如下 note 格式

同一文档内的标题锚点，无需 /tidb-specific-system-variables.md 部分

Suggested change

注意：从 5.0.0 版本开始，该变量已被废弃，请使用 [tidb_executor_concurrency](/tidb-specific-system-variables.md#tidb_executor_concurrency) 进行设置。

> **注意：**

>

> 从 5.0.0 版本开始，该变量将被废弃，请使用 [tidb_executor_concurrency](#tidb_executor_concurrency) 进行设置。

Signed-off-by: niedhui <niedhui@gmail.com>

lilin90 · 2020-07-30T13:13:11Z

@TomShawn Would you please help resolve the conflict? Thanks!

TomShawn · 2020-07-31T05:19:10Z

@TomShawn Would you please help resolve the conflict? Thanks!

Conflict resolved, PTAL

scsldb · 2020-07-31T06:12:21Z

 - 默认值：20000
 - 这个变量用来设置 index lookup 操作的 batch 大小，AP 类应用适合较大的值，TP 类应用适合较小的值。

+### `tidb_executor_concurrency` <span class="version-mark">从 v5.0 版本开始引入</span>


当前 5.0 还没有发布，文档中就出现 5.0 不太合适

SunRunAway · 2020-07-31T11:10:09Z

Let's hold this PR before the release of 5.0

ti-srebot · 2020-08-02T11:28:00Z

@SunRunAway, @TomShawn, @scsldb, @lilin90, PTAL.

ti-srebot · 2020-08-04T11:28:44Z

@SunRunAway, @TomShawn, @scsldb, @lilin90, PTAL.

SunRunAway · 2021-01-04T07:52:39Z

@XuHuaiyu PTAL

ti-srebot · 2021-01-06T07:53:07Z

@SunRunAway, @TomShawn, @scsldb, @lilin90, PTAL.

morgo · 2021-01-11T19:35:46Z

Can we please merge + translate this? It is an important change, with no user documentation so far.

XuHuaiyu

LGTM

ti-srebot · 2021-01-12T09:14:07Z

@XuHuaiyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn

LGTM

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-01-12T09:56:20Z

cherry pick to release-5.0 in PR #5298

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: niedhui <niedhui@gmail.com>

add executor_concurrency doc

098b758

Signed-off-by: niedhui <niedhui@gmail.com>

niedhui force-pushed the executor_concurrency branch from baa53ea to 098b758 Compare July 15, 2020 16:16

TomShawn requested review from SunRunAway and TomShawn July 16, 2020 01:59

TomShawn self-assigned this Jul 16, 2020

TomShawn added translation/doing This PR’s assignee is translating this PR. v5.0 This PR/issue applies to TiDB v5.0 size/small Changes of a small size. labels Jul 16, 2020

SunRunAway reviewed Jul 16, 2020

View reviewed changes

TomShawn reviewed Jul 16, 2020

View reviewed changes

TomShawn requested review from TomShawn and scsldb July 16, 2020 06:00

niedhui force-pushed the executor_concurrency branch from 6a505ff to 56d983d Compare July 16, 2020 06:36

TomShawn reviewed Jul 16, 2020

View reviewed changes

add doc for deprecated varialbes

6e820e2

Signed-off-by: niedhui <niedhui@gmail.com>

niedhui force-pushed the executor_concurrency branch from 56d983d to 6e820e2 Compare July 16, 2020 06:39

TomShawn reviewed Jul 16, 2020

View reviewed changes

niedhui and others added 2 commits July 16, 2020 14:54

try fix link

e1f5a0a

Signed-off-by: niedhui <niedhui@gmail.com>

correct note format

21f3ea5

lilin90 added the status/PTAL This PR is ready for reviewing. label Jul 30, 2020

TomShawn added 2 commits July 31, 2020 13:05

Merge branch 'master' into pr/3975

6ad93e2

add back initial changes

f56d313

scsldb reviewed Jul 31, 2020

View reviewed changes

lilin90 reviewed Jul 31, 2020

View reviewed changes

TomShawn and others added 4 commits October 9, 2020 20:45

Merge branch 'master' into executor_concurrency

041d22a

Merge branch 'master' into executor_concurrency

a51021d

Merge branch 'master' into executor_concurrency

430f64f

Merge branch 'master' into executor_concurrency

9a77cbd

TomShawn added the needs-cherry-pick-5.0 label Dec 29, 2020

Merge branch 'master' into executor_concurrency

75126f3

Merge branch 'master' into executor_concurrency

1b4e9ee

morgo mentioned this pull request Jan 11, 2021

improve system-variables documentation pingcap/docs#4598

Merged

10 tasks

XuHuaiyu reviewed Jan 12, 2021

View reviewed changes

TomShawn removed the status/DNM label Jan 12, 2021

TomShawn added 2 commits January 12, 2021 17:28

Merge branch 'master' into executor_concurrency

a5dc886

refine language

4975350

TomShawn approved these changes Jan 12, 2021

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2021

TomShawn merged commit 3179db6 into pingcap:master Jan 12, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 12, 2021

cherry pick pingcap#3975 to release-5.0

06c1874

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jan 12, 2021

Add doc for tidb_executor_concurrency (#3975) #5298

Merged

5 tasks

TomShawn pushed a commit that referenced this pull request Jan 12, 2021

cherry pick #3975 to release-5.0 (#5298)

b22ef1a

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: niedhui <niedhui@gmail.com>

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 12, 2021

TomShawn mentioned this pull request Jan 12, 2021

Add doc for tidb_executor_concurrency pingcap/docs#4602

Merged

10 tasks

This was referenced Jan 12, 2021

Add doc for tidb_executor_concurrency (#4602) pingcap/docs#4603

Merged

improve system-variables documentation (#4598) pingcap/docs#4647

Merged

TomShawn mentioned this pull request Feb 19, 2021

improve system-variables documentation #5541

Merged

10 tasks

ti-srebot mentioned this pull request Feb 23, 2021

improve system-variables documentation (#5541) #5586

Merged

10 tasks


		对于从 5.0.0 之前的版本升级到 5.0.0 的系统，如果用户对上述七个变量没有做过改动（即 `tidb_hash_join_concurrency` 值为5，其他值为4），则会迁移到使用 `tidb_executor_concurrency` 来统一管理并发度，否则继续沿用之前的变量值对相应的算子做并发控制。

		### tidb_index_lookup_concurrency


		默认值：5

		这个变量用来设置 index lookup，index lookup join，hash join，hash aggregation，window，projection 算子的并发度。

		`tidb_executor_concurrency` 主要整合了之前的 `tidb_index_lookup_concurrency`，`tidb_index_lookup_join_concurrency`，`tidb_hash_join_concurrency`，`tidb_hashagg_partial_concurrency`，`tidb_hashagg_final_concurrency`，`tidb_projection_concurrency` 及 `tidb_window_concurrency` 这七个系统变量，方便管理。

		用户仍可以对上述七个系统变量做单独修改（会有废弃警告），修改只影响单个算子，后续对 `tidb_executor_concurrency` 的修改也不会影响该算子。可以通过将其值设置为`-1`，还原成通过 `tidb_executor_concurrency` 来管理该算子的并发度。


		这个变量用来设置 index lookup 操作的 batch 大小，AP 类应用适合较大的值，TP 类应用适合较小的值。

		### tidb_executor_concurrency <span class="version-mark">从 v5.0 版本开始引入</span>


		这个变量用来设置 index lookup 操作的并发度，AP 类应用适合较大的值，TP 类应用适合较小的值。

		注意：从 5.0.0 版本开始，该变量已被废弃，请使用 [tidb_executor_concurrency](/tidb-specific-system-variables.md#tidb_executor_concurrency) 进行设置。

-注意：从 5.0.0 版本开始，该变量已被废弃，请使用 [tidb_executor_concurrency](/tidb-specific-system-variables.md#tidb_executor_concurrency) 进行设置。
+> **注意：**
+>
+> 从 5.0.0 版本开始，该变量将被废弃，请使用 [tidb_executor_concurrency](#tidb_executor_concurrency) 进行设置。

Conversation

niedhui commented Jul 15, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

CLAassistant commented Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lilin90 commented Jul 30, 2020

Uh oh!

TomShawn commented Jul 31, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunRunAway commented Jul 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-srebot commented Aug 2, 2020

Uh oh!

ti-srebot commented Aug 4, 2020

Uh oh!

SunRunAway commented Jan 4, 2021

Uh oh!

ti-srebot commented Jan 6, 2021

Uh oh!

morgo commented Jan 11, 2021

Uh oh!

XuHuaiyu left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jan 12, 2021

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jan 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

CLAassistant commented Jul 15, 2020 •

edited

Loading