Skip to content

Update FAQs#4047

Merged
lilin90 merged 11 commits into
pingcap:masterfrom
Joyinqin:update-tidb-faqs
Jul 29, 2020
Merged

Update FAQs#4047
lilin90 merged 11 commits into
pingcap:masterfrom
Joyinqin:update-tidb-faqs

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Jul 24, 2020

What is changed, added or deleted? (Required)

Update out of date FAQs.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

SQL FAQs; Deploy and Maintain FAQs

@ti-srebot ti-srebot added needs-cherry-pick-3.1 size/small Changes of a small size. labels Jul 24, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

These labels are not found trasnlation/from-docs.

@Joyinqin
Copy link
Copy Markdown
Contributor Author

/label translation/from-docs, size/small, needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, needs-cherry-pick-2.1

@ti-srebot ti-srebot added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Jul 24, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

@yikeke PTAL

@Joyinqin
Copy link
Copy Markdown
Contributor Author

/cc yikeke

@ti-srebot ti-srebot requested a review from yikeke July 25, 2020 04:46
@yikeke yikeke requested review from lilin90 and removed request for yikeke July 27, 2020 05:04
Comment thread faq/deploy-and-maintain-faq.md Outdated
Comment thread faq/sql-faq.md Outdated
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jul 28, 2020
lilin90 and others added 2 commits July 28, 2020 18:57
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/cc zz-jason

@ti-srebot ti-srebot requested a review from zz-jason July 28, 2020 13:30
Comment thread faq/sql-faq.md Outdated
Comment thread faq/sql-faq.md Outdated
Joyinqin and others added 2 commits July 29, 2020 11:45
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 29, 2020

@Joyinqin Please fix the lint failure.

Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 29, 2020
@lilin90 lilin90 merged commit 7f0c076 into pingcap:master Jul 29, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2020
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-2.1 in PR #4089

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2020
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 in PR #4090

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2020
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #4091

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2020
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #4092

@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 29, 2020

@Joyinqin Since the organization of FAQs in v3.1, v3.0, v2.1 is quite different from that of dev and v4.0, I've closed the cherry-picked PRs to those three branches. Please create another PR to the release-3.1 branch according to pingcap/docs#3153 and then cherry pick to v3.0 and v2.1 in that PR.

lilin90 pushed a commit that referenced this pull request Jul 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@Joyinqin Joyinqin deleted the update-tidb-faqs branch July 29, 2020 05:37
This was referenced Jul 29, 2020
This was referenced Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/require-change Needs the author to address comments. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants