Skip to content

tidb-lightning: update docs#4094

Merged
ti-srebot merged 30 commits into
pingcap:masterfrom
Joyinqin:tidb-lightning
Aug 3, 2020
Merged

tidb-lightning: update docs#4094
ti-srebot merged 30 commits into
pingcap:masterfrom
Joyinqin:tidb-lightning

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Jul 29, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Translate changes of updated docs.

  • TLS configuration
  • TiKV Importer now supports listening on 0.0.0.0
  • TiKV Importer no longer requires Pushgateway for Prometheus
  • CSV strict-format config for optional parallel speed up
  • TiDB's default SQL mode is no longer strict
  • Several new CLI parameters are exposed

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Jul 29, 2020

/label needs-cherry-pick-4.0, size/medium, translation/from-docs

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/medium Changes of a medium size. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jul 29, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Jul 29, 2020

/cc yikeke, kennytm

@ti-srebot ti-srebot requested review from kennytm and yikeke July 29, 2020 06:43
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 29, 2020

/assign

@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jul 29, 2020

/assign cancel

@yikeke yikeke requested review from lilin90 and removed request for yikeke July 29, 2020 07:46
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 29, 2020

Please help review this PR, thanks! @lilin90

@lilin90 lilin90 requested review from TomShawn and removed request for lilin90 July 29, 2020 08:07
@lilin90 lilin90 added the status/PTAL This PR is ready for reviewing. label Jul 29, 2020
kennytm
kennytm reviewed Jul 29, 2020
View reviewed changes
Comment thread tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated
Comment thread tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Jul 29, 2020

Why do we quote "256 MB" as `256 MB` now? File size is not code.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 2, 2020

@kennytm, @TomShawn, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 2, 2020

@Joyinqin, please update your pull request.

TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/monitor-tidb-lightning.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
TomShawn
TomShawn reviewed Aug 3, 2020
View reviewed changes
Comment thread tidb-lightning/tidb-lightning-configuration.md Outdated
TomShawn
TomShawn approved these changes Aug 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels Aug 3, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 3, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 8bc72fd into pingcap:master Aug 3, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 3, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#4094 to release-4.0
42daa31 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 3, 2020

cherry pick to release-4.0 in PR #4176

TomShawn added a commit that referenced this pull request Aug 3, 2020
@ti-srebot @Joyinqin @TomShawn
tidb-lightning: update docs (#4094) (#4176)
f266165 
* cherry pick #4094 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin Joyinqin deleted the tidb-lightning branch August 3, 2020 13:30
@kennytm kennytm mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Joyinqin @lilin90 @yikeke @kennytm @ti-srebot @TomShawn