Skip to content

Update dumpling-overview.md#4096

Merged
ti-srebot merged 18 commits into
masterfrom
fix-dumpling
Jul 31, 2020
Merged

Update dumpling-overview.md#4096
ti-srebot merged 18 commits into
masterfrom
fix-dumpling

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jul 29, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  1. 参数/指令 -> 选项 （ref：difference between a flag, an option, and an argument?, difference between a command line flag and a command line option? - Super User）
  2. 把中文文档里的英文译为了中文
  3. 选项表里的一些表述优化

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke marked this pull request as ready for review July 29, 2020 07:40
@yikeke yikeke requested review from lichunzhu and lilin90 July 29, 2020 07:40
@yikeke yikeke added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. status/PTAL This PR is ready for reviewing. labels Jul 29, 2020
@yikeke yikeke mentioned this pull request Jul 29, 2020
Merged
9 tasks
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
yikeke
yikeke commented Jul 30, 2020
View reviewed changes
Comment thread dumpling-overview.md Outdated
lichunzhu
lichunzhu approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

@lichunzhu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jul 30, 2020

PTAL @lilin90

@yikeke yikeke added status/LGT1 Indicates that a PR has LGTM 1. and removed status/PTAL This PR is ready for reviewing. labels Jul 30, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
9 tasks
lilin90
lilin90 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 31, 2020
@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jul 31, 2020

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 31, 2020

@yikeke Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jul 31, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 31, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit bc66306 into master Jul 31, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 31, 2020
@yikeke @ti-srebot
cherry pick pingcap#4096 to release-4.0
5142c25 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 31, 2020

cherry pick to release-4.0 in PR #4146

@yikeke yikeke deleted the fix-dumpling branch July 31, 2020 10:17
yikeke added a commit that referenced this pull request Jul 31, 2020
@ti-srebot @yikeke
cherry pick #4096 to release-4.0 (#4146)
4b48daa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

+1 more reviewer

@lichunzhu lichunzhu lichunzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yikeke @ti-srebot @lichunzhu @lilin90