Skip to content

Update backup-and-restore-tool.md#4121

Merged
TomShawn merged 1 commit into
pingcap:masterfrom
ireneontheway:br/version
Jul 30, 2020
Merged

Update backup-and-restore-tool.md#4121
TomShawn merged 1 commit into
pingcap:masterfrom
ireneontheway:br/version

Conversation

@ireneontheway
Copy link
Copy Markdown
Contributor

@ireneontheway ireneontheway commented Jul 30, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Update BR --version flag.
To close #2754.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ireneontheway ireneontheway added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-3.1 status/PTAL This PR is ready for reviewing. labels Jul 30, 2020
TomShawn
TomShawn approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

@TomShawn Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 30, 2020
@TomShawn TomShawn merged commit 8dadf81 into pingcap:master Jul 30, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 30, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#4121 to release-3.1
a5307f6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

cherry pick to release-3.1 in PR #4122

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 30, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#4121 to release-4.0
e70a86e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

cherry pick to release-4.0 in PR #4123

ireneontheway added a commit that referenced this pull request Jul 30, 2020
@ti-srebot @ireneontheway
cherry pick #4121 to release-3.1 (#4122)
a5f6e95 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
ireneontheway added a commit that referenced this pull request Jul 30, 2020
@ti-srebot @ireneontheway
cherry pick #4121 to release-4.0 (#4123)
5010ad7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus Awaiting requested review from overvenus

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changed: br Sub command "version" is now an option --version

3 participants

@ireneontheway @ti-srebot @TomShawn