Skip to content

stmt-reference, sysvars: Document dml-batch-size#4590

Merged
TomShawn merged 8 commits into
pingcap:masterfrom
ireneontheway:dml-batch-size02
Sep 27, 2020
Merged

stmt-reference, sysvars: Document dml-batch-size#4590
TomShawn merged 8 commits into
pingcap:masterfrom
ireneontheway:dml-batch-size02

Conversation

@ireneontheway
Copy link
Copy Markdown
Contributor

@ireneontheway ireneontheway commented Sep 24, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Part of pingcap/docs#3155

Only relevant to master.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs This PR is translated from a PR in pingcap/docs. size/small Changes of a small size. labels Sep 24, 2020
@ireneontheway ireneontheway marked this pull request as ready for review September 25, 2020 03:55
@TomShawn TomShawn removed the request for review from kolbe September 25, 2020 03:57
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread sql-statements/sql-statement-load-data.md Outdated
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread sql-statements/sql-statement-load-data.md Outdated
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread system-variables.md Outdated
@ireneontheway @TomShawn
Apply suggestions from code review
5a0f3ae 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Sep 27, 2020

@TomShawn Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 0.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/can-merge Indicates a PR has been approved by a committer. labels Sep 27, 2020
ireneontheway and others added 2 commits September 27, 2020 11:05
@ireneontheway @TomShawn
Apply suggestions from code review
5574e6f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ireneontheway
Merge branch 'master' into dml-batch-size02
bd4b8ae
@TomShawn TomShawn requested a review from cfzjywxk September 27, 2020 03:20
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Sep 27, 2020
@cfzjywxk
Copy link
Copy Markdown
Contributor

cfzjywxk commented Sep 27, 2020

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Sep 27, 2020

@cfzjywxk,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn approved these changes Sep 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
TomShawn
TomShawn reviewed Sep 27, 2020
View reviewed changes
Comment thread sql-statements/sql-statement-load-data.md Outdated
@TomShawn TomShawn merged commit a72c713 into pingcap:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ireneontheway @ti-srebot @cfzjywxk @TomShawn