Skip to content

tidb-configuration-file: remove allow-auto-random from config manual#4642

Merged
TomShawn merged 1 commit into
pingcap:masterfrom
tangenta:autorand-rm-config-doc
Oct 10, 2020
Merged

tidb-configuration-file: remove allow-auto-random from config manual#4642
TomShawn merged 1 commit into
pingcap:masterfrom
tangenta:autorand-rm-config-doc

Conversation

@tangenta
Copy link
Copy Markdown
Contributor

@tangenta tangenta commented Oct 9, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

Copy link
Copy Markdown
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@wjhuang2016,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Oct 9, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Oct 9, 2020

是否需要说明 auto random 是默认开启的?

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Oct 9, 2020
@wjhuang2016
Copy link
Copy Markdown
Member

是否需要说明 auto random 是默认开启的?

不需要的

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Oct 9, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2020
@TomShawn TomShawn merged commit c29dca6 into pingcap:master Oct 10, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Oct 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #4650

TomShawn added a commit that referenced this pull request Oct 10, 2020
…4642) (#4650)

* cherry pick #4642 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin
Copy link
Copy Markdown
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Oct 13, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor

/unlabel translation/doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants