Skip to content

Add tiup-cluster-topology.md#4735

Closed
july2993 wants to merge 14 commits into
pingcap:masterfrom
july2993:cluster_topo
Closed

Add tiup-cluster-topology.md#4735
july2993 wants to merge 14 commits into
pingcap:masterfrom
july2993:cluster_topo

Conversation

@july2993
Copy link
Copy Markdown
Contributor

@july2993 july2993 commented Oct 26, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

- 添加 tiup-cluster-topology.md
- simple-tidb-binlog.yaml 添加 commit_ts 保持与 https://docs.pingcap.com/zh/tidb/stable/tidb-binlog-deployment-topology
 一致。
- 添加 commit_ts 的说明在 tidb-binlog-deployment-topology
+ 默认值:"{global.deploy_dir}/tispark-master-{port}"

### `listen_host`

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AstroProfundis
帮补充下下这几个 spark 的

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPARK_LOCAL_IP 的值,默认为空

@july2993
Copy link
Copy Markdown
Contributor Author

@lonng @lucklove PTAL

@july2993
Copy link
Copy Markdown
Contributor Author

cc @superlzs0476

@TomShawn TomShawn self-assigned this Oct 26, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/large Changes of a large size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Oct 26, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@AstroProfundis, @lonng, @lucklove, @superlzs0476, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

@AstroProfundis, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot
Copy link
Copy Markdown
Contributor

@AstroProfundis, @lonng, @lucklove, @superlzs0476, PTAL.

Copy link
Copy Markdown
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@lonng, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot
Copy link
Copy Markdown
Contributor

@AstroProfundis, @lonng, @lucklove, @superlzs0476, PTAL.


### `group`

+ 部署用户的用户组
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个有默认值吗

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个默认值为 user 对应的值


### host

+ 部署机器的 ip 。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有默认值吗

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没写的都没


### host

+ 部署机器的 ip 。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有默认值吗


### `port`

+ 默认值:20160
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少描述?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个描述写什么比较合适?TiKV 的“主端口”的话,听起来怪怪的。。。


### `status_port`

+ 默认值:20180
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少描述?

Comment on lines +287 to +308

+ 默认值:9000

### `http_port`

+ 默认值:8123

### `flash_service_port`

+ 默认值:3930

### `flash_proxy_port`

+ 默认值:20170

### `flash_proxy_status_port`

+ 默认值:20292

### `metrics_port`

+ 默认值:8234
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少描述


+ 覆盖 {server_configs.tiflash} 的配置。

> **注意:**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意太长了还包含配置示例,建议不用注意格式。


> **注意:**
>
> `path_realtime_mode` 只有 `tiflash_servers.data_dir` 配置了多个路径时才有做用。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> `path_realtime_mode` 只有 `tiflash_servers.data_dir` 配置了多个路径时才有做用
> `path_realtime_mode` 只有 `tiflash_servers.data_dir` 配置了多个路径时才有作用


### `port`

+ 默认值:8249
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少描述


## cdc_servers

部署 cdc 的实例。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TiCDC 还是 cdc?

Comment on lines +491 to +501
+ 默认值:7078

### `web_port`

+ 默认值:8081

### spark_config

+ 加入到 `spark-defaults.conf` 中的自定义配置项。

### spark_env
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少描述


### `port`

+ 默认值:9090
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines +619 to +623
+ 默认值:9093

### `cluster_port`

+ 默认值:9094
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少描述

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Nov 6, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot
Copy link
Copy Markdown
Contributor

@july2993, please update your pull request.

@ti-srebot
Copy link
Copy Markdown
Contributor

@july2993 july2993 closed this Nov 10, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

@july2993 Why closing this PR?

@lucklove
Copy link
Copy Markdown
Member

@TomShawn I'll do this in another PR: #4868

@TomShawn TomShawn removed needs-cherry-pick-4.0 size/large Changes of a large size. status/require-change Needs the author to address comments. translation/doing This PR’s assignee is translating this PR. labels Nov 10, 2020
@TomShawn TomShawn removed their assignment Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants