Skip to content

Revert "*: remove expression index out of experimental feature."#5089

Merged
TomShawn merged 2 commits into
pingcap:masterfrom
wjhuang2016:revert-4641-refine_expr_index
Dec 15, 2020
Merged

Revert "*: remove expression index out of experimental feature."#5089
TomShawn merged 2 commits into
pingcap:masterfrom
wjhuang2016:revert-4641-refine_expr_index

Conversation

@wjhuang2016
Copy link
Copy Markdown
Member

@wjhuang2016 wjhuang2016 commented Dec 14, 2020 •
edited
Loading

Reverts #4641

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn self-assigned this Dec 15, 2020
@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. v5.0 This PR/issue applies to TiDB v5.0 labels Dec 15, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Dec 15, 2020

Why reverting #4641?

djshow832
djshow832 reviewed Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 15, 2020

@djshow832, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@wjhuang2016
Copy link
Copy Markdown
Member Author

wjhuang2016 commented Dec 15, 2020

Why reverting #4641?

Expression index is not GA in sprint1.

TomShawn
TomShawn approved these changes Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2020
@TomShawn TomShawn merged commit a343ccf into pingcap:master Dec 15, 2020
@TomShawn TomShawn assigned Joyinqin and unassigned TomShawn Dec 15, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Dec 18, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Dec 18, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Dec 18, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Dec 18, 2020
@Joyinqin Joyinqin mentioned this pull request Dec 18, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djshow832 djshow832 djshow832 left review comments

@crazycs520 crazycs520 Awaiting requested review from crazycs520

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wjhuang2016 @TomShawn @ti-srebot @Joyinqin @djshow832