sql-statements: use EBNF to render syntax diagrams - third batch#5540
Merged
ti-chi-bot merged 5 commits intoApr 26, 2021
Conversation
CharLotteiu
added
needs-cherry-pick-4.0
size/large
Contributor
2 similar comments
Contributor
Contributor
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
added
size/XXL
kennytm
reviewed
Apr 25, 2021
| @@ -26,6 +26,24 @@ TiDB 支持 `EXPLAIN [options] FOR CONNECTION connection_id`，但与 MySQL 的 | |||
|
|
|||
|  | |||
Contributor
There was a problem hiding this comment.
the images are still here 🤔
| @@ -30,6 +30,42 @@ aliases: ['/docs-cn/dev/sql-statements/sql-statement-modify-column/','/docs-cn/d | |||
|
|
|||
|  | |||
| @@ -34,6 +34,31 @@ aliases: ['/docs-cn/dev/sql-statements/sql-statement-replace/','/docs-cn/dev/ref | |||
|
|
|||
|  | |||
Contributor
|
/sig migrate docs |
ti-chi-bot
added
area/migrate
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 4119ba2 |
ti-chi-bot
added
the
status/can-merge
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Apr 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-4.0 in PR #6168 |
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Apr 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-5.0 in PR #6169 |
Contributor
|
/assign @CharLotteiu |
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 26, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 26, 2021
10 tasks
Contributor
Author
|
/remove-translation doing |
ti-chi-bot
added
translation/done
This was referenced Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
This PR changes the synopsis sections of BEGIN, CHANGE, COMMIT, CREATE, DEALLOCATE, DELETE, DO, and DROP statements to use the ```ebnf+diagrm block, replacing the original image-based sqlgrams. It is a follow-up PR to pingcap/docs#4389.
To avoid making one single PR too large, I will open 4-5 follow-up PRs to process sql-statements files in batches. And I will delete all image files in the last PR in case of any display issues.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?