Skip to content

benchmark: add description to explain the non-index test result#5719

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
TomShawn:patch-1
Mar 12, 2021
Merged

benchmark: add description to explain the non-index test result#5719
ti-chi-bot merged 1 commit into
pingcap:masterfrom
TomShawn:patch-1

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Mar 11, 2021

What is changed, added or deleted? (Required)

Add a description to clarity that tables in the benchmark test have no index created.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-4.0 labels Mar 11, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Mar 11, 2021

/status PTAL
/cc JaySon-Huang CharLotteiu
/size small
/translation doing

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 11, 2021
JaySon-Huang
JaySon-Huang approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 11, 2021

@JaySon-Huang: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharLotteiu
Copy link
Copy Markdown
Contributor

CharLotteiu commented Mar 12, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Mar 12, 2021

/assign

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 041682d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@ti-chi-bot ti-chi-bot merged commit a831c28 into pingcap:master Mar 12, 2021
@TomShawn TomShawn deleted the patch-1 branch March 12, 2021 03:55
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 12, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5719 to release-4.0
1b1a216 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 12, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 12, 2021

cherry pick to release-4.0 in PR #5720

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 12, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5719 to release-5.0
d31212d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 12, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 12, 2021

cherry pick to release-5.0 in PR #5721

ti-chi-bot pushed a commit that referenced this pull request Mar 12, 2021
@ti-srebot
benchmark: add description to explain the non-index test result (#5719)…
8fc31f7 
… (#5720)
ti-chi-bot pushed a commit that referenced this pull request Mar 12, 2021
@ti-srebot
benchmark: add description to explain the non-index test result (#5719)…
99dacd7 
… (#5721)
@TomShawn TomShawn mentioned this pull request Mar 12, 2021
Merged
10 tasks
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Mar 12, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 12, 2021
This was referenced Mar 16, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CharLotteiu CharLotteiu Awaiting requested review from CharLotteiu

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/small Changes of a small size. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TomShawn @ti-chi-bot @CharLotteiu @ti-srebot @JaySon-Huang @ran-huang