Skip to content

Update backup-and-restore-storages.md#5772

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
liufugen-yewu:patch-2
Apr 13, 2021
Merged

Update backup-and-restore-storages.md#5772
ti-chi-bot merged 7 commits into
pingcap:masterfrom
liufugen-yewu:patch-2

Conversation

@liufugen-yewu
Copy link
Copy Markdown
Contributor

@liufugen-yewu liufugen-yewu commented Mar 18, 2021 •
edited
Loading

使用 lightning 导入 s3上的数据时，如果使用的是endpoint 进行区分，需要进行force-path-style参数的设置。

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@liufugen-yewu
Update backup-and-restore-storages.md
25d3a63 
使用 lightning 导入 s3上的数据时，如果使用的是endpoint 进行区分，需要进行force-path-style参数的设置。
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2021
@liufugen-yewu
Copy link
Copy Markdown
Contributor Author

liufugen-yewu commented Mar 18, 2021

\cc @TomShawn

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 18, 2021

/label needs-cherry-pick-5.0

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 18, 2021

/label needs-cherry-pick-4.0

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 18, 2021

/status PTAL
/size small
/assign Joyinqin
/cc @kennytm
/translation doing

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Mar 18, 2021
@ti-chi-bot ti-chi-bot requested a review from kennytm March 18, 2021 10:39
@ti-chi-bot ti-chi-bot added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 18, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 20, 2021

@kennytm, PTAL.

@liufugen-yewu
Copy link
Copy Markdown
Contributor Author

liufugen-yewu commented Mar 22, 2021

\ cc @kennytm，我的提交有什么问题吗？？

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Mar 22, 2021

@liufugen-yewu this is considered a bug (pingcap/br#903), can you restrict the suggestion to "before v4.0.13"?

@ti-chi-bot ti-chi-bot removed the size/small Changes of a small size. label Mar 22, 2021
@liufugen-yewu
Copy link
Copy Markdown
Contributor Author

liufugen-yewu commented Mar 22, 2021

@ liufugen-yewu这被认为是一个错误（pingcap / br＃903），您可以将建议限制为“在v4.0.13之前”吗？

我改成4.0版本，但是我想问一下，是我添加的有问题，还是冲突了

@liufugen-yewu
Copy link
Copy Markdown
Contributor Author

liufugen-yewu commented Mar 31, 2021

i think it can be phrased like https://github.com/pingcap/docs-cn/blob/release-4.0/br/backup-and-restore-use-cases.md#%E5%A4%87%E4%BB%BD%E5%89%8D%E7%9A%84%E5%87%86%E5%A4%87%E5%B7%A5%E4%BD%9C, but note that the target branch is release-4.0, not master.

I have modified it according to your request, please check if there are any problems.

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Mar 31, 2021

LGTM

TomShawn
TomShawn reviewed Apr 13, 2021
View reviewed changes
Comment thread br/backup-and-restore-storages.md Outdated
@yikeke @TomShawn
Update br/backup-and-restore-storages.md
3493cb2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 13, 2021

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 13, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 13, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 13, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 13, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3493cb2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit 91e4cea into pingcap:master Apr 13, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021
@liufugen-yewu @ti-srebot
cherry pick pingcap#5772 to release-4.0
92e96c9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 13, 2021

cherry pick to release-4.0 in PR #6029

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021
@liufugen-yewu @ti-srebot
cherry pick pingcap#5772 to release-5.0
3d35d71 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 13, 2021

cherry pick to release-5.0 in PR #6030

ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Update backup-and-restore-storages.md (#5772) (#6030)
9d664ff
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Update backup-and-restore-storages.md (#5772) (#6029)
e35cb04
@Joyinqin Joyinqin mentioned this pull request Apr 14, 2021
Merged
11 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Apr 14, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 14, 2021
This was referenced Apr 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm Awaiting requested review from kennytm

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@liufugen-yewu @TomShawn @ti-srebot @kennytm @ti-chi-bot @Joyinqin @yikeke