Skip to content

Update compatibility of BR#5905

Merged
ti-chi-bot merged 4 commits into
pingcap:masterfrom
YuJuncen:patch-1
Apr 7, 2021
Merged

Update compatibility of BR#5905
ti-chi-bot merged 4 commits into
pingcap:masterfrom
YuJuncen:patch-1

Conversation

@YuJuncen
Copy link
Copy Markdown
Contributor

@YuJuncen YuJuncen commented Apr 1, 2021

update compatibility of BR

First-time contributors' checklist

What is changed, added or deleted? (Required)

After introducing clustered index in 5.0, there are some new compatibility problems of BR.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@YuJuncen
Update backup-and-restore-tool.md
4ecf2b9 
update compatibility of BR
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2021
overvenus
overvenus reviewed Apr 1, 2021
View reviewed changes
Comment thread br/backup-and-restore-tool.md Outdated
@overvenus
Copy link
Copy Markdown
Member

overvenus commented Apr 1, 2021

rest lgtm

@YuJuncen @overvenus
Update br/backup-and-restore-tool.md
8fc1da3 
Co-authored-by: Neil Shen <overvenus@gmail.com>
TomShawn
TomShawn reviewed Apr 1, 2021
View reviewed changes
Comment thread br/backup-and-restore-tool.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 1, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation doing
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 1, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 1, 2021

/assign Joyinqin

YuJuncen and others added 2 commits April 7, 2021 10:51
@YuJuncen @TomShawn
Update br/backup-and-restore-tool.md
99c052e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@YuJuncen
Update backup-and-restore-tool.md
9609b53
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 7, 2021

/unassign Joyinqin
/assign

@ti-chi-bot ti-chi-bot assigned TomShawn and unassigned Joyinqin Apr 7, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 7, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 7, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 7, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9609b53

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit 0b851ba into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 7, 2021
@YuJuncen @ti-srebot
cherry pick pingcap#5905 to release-4.0
76ddf48 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
7 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 7, 2021

cherry pick to release-4.0 in PR #5968

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 7, 2021
@YuJuncen @ti-srebot
cherry pick pingcap#5905 to release-5.0
7125402 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
7 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 7, 2021

cherry pick to release-5.0 in PR #5969

ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
Update compatibility of BR (#5905) (#5969)
75c7e91
ti-chi-bot pushed a commit that referenced this pull request Apr 12, 2021
@ti-srebot
Update compatibility of BR (#5905) (#5968)
6ad194d
@TomShawn TomShawn mentioned this pull request Apr 12, 2021
Merged
10 tasks
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 12, 2021

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 12, 2021
This was referenced Apr 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YuJuncen @overvenus @TomShawn @ti-chi-bot @ti-srebot @Joyinqin