Skip to content

[v5.0.1/v4.0.13] ticdc: add explicit_defaults_for_timestamp compatibility troubleshoot#6032

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
amyangfei:cdc-explicit_defaults_for_timestamp
May 28, 2021
Merged

[v5.0.1/v4.0.13] ticdc: add explicit_defaults_for_timestamp compatibility troubleshoot#6032
ti-chi-bot merged 2 commits into
pingcap:masterfrom
amyangfei:cdc-explicit_defaults_for_timestamp

Conversation

@amyangfei
Copy link
Copy Markdown
Contributor

@amyangfei amyangfei commented Apr 14, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add explicit_defaults_for_timestamp compatibility troubleshoot in TiCDC. ref: pingcap/ticdc#1638

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2021
@amyangfei
Copy link
Copy Markdown
Contributor Author

amyangfei commented Apr 14, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0

@overvenus
Copy link
Copy Markdown
Member

overvenus commented Apr 14, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 15, 2021

/label requires-version-specific-changes
/assign
/label for-future-release

@ti-chi-bot ti-chi-bot added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Apr 15, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 15, 2021

/translation doing

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 15, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 16, 2021

/cc @yikeke

@ti-chi-bot ti-chi-bot requested a review from yikeke April 16, 2021 09:10
@yikeke yikeke changed the title ticdc: add explicit_defaults_for_timestamp compatibility troubleshoot [v5.0.1/v4.0.13] ticdc: add explicit_defaults_for_timestamp compatibility troubleshoot Apr 19, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus
  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2021
@amyangfei amyangfei mentioned this pull request May 9, 2021
Closed
2 tasks
@TomShawn TomShawn removed the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label May 28, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 28, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3776201

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2021
@ti-chi-bot ti-chi-bot merged commit 923bc60 into pingcap:master May 28, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
@amyangfei @ti-chi-bot
This is an automated cherry-pick of pingcap#6032
a95f728 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 28, 2021

In response to a cherrypick label: new pull request created: #6367.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 28, 2021
@amyangfei @ti-chi-bot
This is an automated cherry-pick of pingcap#6032
673cf8c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 28, 2021

In response to a cherrypick label: new pull request created: #6368.

ti-chi-bot added a commit that referenced this pull request May 28, 2021
@ti-chi-bot
[v5.0.1/v4.0.13] ticdc: add explicit_defaults_for_timestamp compatibi…
d84cee3 
…lity troubleshoot (#6032) (#6367)
ti-chi-bot added a commit that referenced this pull request May 28, 2021
@ti-chi-bot
[v5.0.1/v4.0.13] ticdc: add explicit_defaults_for_timestamp compatibi…
ed8af19 
…lity troubleshoot (#6032) (#6368)
@amyangfei amyangfei deleted the cdc-explicit_defaults_for_timestamp branch June 22, 2021 06:12
@TomShawn TomShawn mentioned this pull request Aug 5, 2021
Merged
11 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 5, 2021
This was referenced Aug 6, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amyangfei @overvenus @TomShawn @ti-chi-bot @yikeke