Skip to content

br: minor refinement#6047

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
TomShawn:patch-1
Apr 19, 2021
Merged

br: minor refinement#6047
ti-chi-bot merged 2 commits into
pingcap:masterfrom
TomShawn:patch-1

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Apr 16, 2021

What is changed, added or deleted? (Required)

Make 2 minor refinements on br/backup-and-restore-tool.md to make the Chinese/English version consistent.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2021
@TomShawn TomShawn mentioned this pull request Apr 16, 2021
Merged
10 tasks
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 16, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation done
/assign
/cc @lilin90

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 16, 2021
@ti-chi-bot ti-chi-bot requested a review from lilin90 April 16, 2021 03:02
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 16, 2021
lilin90
lilin90 reviewed Apr 19, 2021
View reviewed changes
Comment thread br/backup-and-restore-tool.md Outdated
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Apr 19, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
This was referenced Apr 19, 2021
Merged
Merged
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 19, 2021

/label require-LGT1
/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 19, 2021

@TomShawn: /merge in this pull request requires 2 /lgtm.

Details

In response to this:

/label require-LGT1
/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 19, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 19, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 19, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5937868

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2021
@ti-chi-bot ti-chi-bot merged commit f146e21 into pingcap:master Apr 19, 2021
@TomShawn TomShawn deleted the patch-1 branch April 19, 2021 11:20
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 19, 2021
@TomShawn @ti-srebot
cherry pick pingcap#6047 to release-4.0
244fe8e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 19, 2021

cherry pick to release-4.0 in PR #6063

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 19, 2021
@TomShawn @ti-srebot
cherry pick pingcap#6047 to release-5.0
52665ff 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 19, 2021

cherry pick to release-5.0 in PR #6064

ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
br: minor refinement (#6047) (#6063)
bfeb640
ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
br: minor refinement (#6047) (#6064)
417d6ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 left review comments

Assignees

@TomShawn TomShawn

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @lilin90 @ti-chi-bot @ti-srebot