Skip to content

explain: add hint about disabling line wrapping with less#6086

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
Joyinqin:explain-overview-update
Apr 20, 2021
Merged

explain: add hint about disabling line wrapping with less#6086
ti-chi-bot merged 5 commits into
pingcap:masterfrom
Joyinqin:explain-overview-update

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Apr 20, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a hint to the EXPLAIN documentation about how to use less -S to view large explain output without line wrapping.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 20, 2021 09:31
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 20, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 20, 2021
TomShawn
TomShawn reviewed Apr 20, 2021
View reviewed changes
Comment thread sql-statements/sql-statement-explain.md Outdated
TomShawn
TomShawn reviewed Apr 20, 2021
View reviewed changes
Comment thread explain-overview.md Outdated
@Joyinqin @TomShawn
Apply suggestions from code review
c4d3329 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Apr 20, 2021
View reviewed changes
Comment thread explain-overview.md Outdated
TomShawn
TomShawn reviewed Apr 20, 2021
View reviewed changes
Comment thread sql-statements/sql-statement-explain.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 20, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 20, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 20, 2021
@Joyinqin @TomShawn
Apply suggestions from code review
f561676 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 20, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 20, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f561676

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2021
@ti-chi-bot ti-chi-bot merged commit 400e0f4 into pingcap:master Apr 20, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#6086 to release-4.0
f72d5ea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 20, 2021

cherry pick to release-4.0 in PR #6091

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 20, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#6086 to release-5.0
dabeb59 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 20, 2021

cherry pick to release-5.0 in PR #6092

ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
explain: add hint about disabling line wrapping with less (#6086) (#6091
8169b12 
)
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
explain: add hint about disabling line wrapping with less (#6086) (#6092
263c4b6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @TomShawn @ti-chi-bot @ti-srebot