Skip to content

Update dashboard FAQ#6178

Closed
shhdgit wants to merge 11 commits into
pingcap:release-4.0from
shhdgit:patch-1
Closed

Update dashboard FAQ#6178
shhdgit wants to merge 11 commits into
pingcap:release-4.0from
shhdgit:patch-1

Conversation

@shhdgit
Copy link
Copy Markdown
Member

@shhdgit shhdgit commented Apr 27, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added a new FAQ for TiDB Dashboard

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from qiancai April 27, 2021 03:11
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/label needs-cherry-pick-5.0
/label needs-cherry-pick-master
/translation done
/cc @breeswish
/assign @shhdgit

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 27, 2021
@ti-chi-bot ti-chi-bot requested a review from breezewish April 27, 2021 03:19
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2021
@TomShawn TomShawn mentioned this pull request Apr 27, 2021
11 tasks
Comment thread dashboard/dashboard-faq.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021
Comment thread dashboard/dashboard-faq.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 27, 2021

/label requires-version-specific-changes
/hold

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 27, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2021
@TomShawn TomShawn closed this May 13, 2021
@TomShawn TomShawn reopened this May 13, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
@shhdgit shhdgit requested a review from breezewish June 22, 2021 04:44
@shhdgit
Copy link
Copy Markdown
Member Author

shhdgit commented Jun 22, 2021

Updated, PTAL.

@TomShawn
Copy link
Copy Markdown
Contributor

@shhdgit Please help confirm whether this PR content applies to v5.1. Thanks~

@shhdgit
Copy link
Copy Markdown
Member Author

shhdgit commented Jun 22, 2021

Yes, v5.1 can also be applied.

Comment thread dashboard/dashboard-faq.md Outdated
Comment thread dashboard/dashboard-faq.md
Co-authored-by: Wenxuan <hi@breeswish.org>
@shhdgit shhdgit requested a review from breezewish June 28, 2021 01:52
Comment thread dashboard/dashboard-faq.md Outdated
Comment thread dashboard/dashboard-faq.md Outdated
shhdgit and others added 2 commits June 29, 2021 10:25
Co-authored-by: Wenxuan <hi@breeswish.org>
@breezewish
Copy link
Copy Markdown
Member

@TomShawn PTAL, thanks!

@TomShawn TomShawn closed this Jun 30, 2021
@TomShawn TomShawn removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-4.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2021
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Jul 26, 2021

This PR is closed because the author created a new PR (#6559) in master to cover the same changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants