Skip to content

binlog: update documents for committs and passoword#6271

Merged
ti-chi-bot merged 8 commits into
pingcap:masterfrom
3pointer:binlog_config
Jul 8, 2021
Merged

binlog: update documents for committs and passoword#6271
ti-chi-bot merged 8 commits into
pingcap:masterfrom
3pointer:binlog_config

Conversation

@3pointer
Copy link
Copy Markdown
Contributor

@3pointer 3pointer commented May 14, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Part solve pingcap/tidb-binlog#1045

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 14, 2021 11:00
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2021
@TomShawn TomShawn requested review from IANTHEREAL and july2993 May 14, 2021 11:17
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels May 14, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 14, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 14, 2021 •
edited
Loading

@3pointer 目前 2.1/3.0/3.1 是非活跃分支，文档站对应的版本都有这样的提示，是否能考虑不 cp 到这三个分支呢？而且本 PR 提到了 BR、Dumpling，如果 cp 到较早分支，还得单独去掉。
image

IANTHEREAL
IANTHEREAL reviewed May 14, 2021
View reviewed changes
Comment thread tidb-binlog/deploy-tidb-binlog.md Outdated
IANTHEREAL
IANTHEREAL reviewed May 14, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
@IANTHEREAL
Copy link
Copy Markdown
Contributor

IANTHEREAL commented May 14, 2021

Rest LGTM

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label May 17, 2021
@TomShawn TomShawn requested a review from IANTHEREAL May 17, 2021 03:14
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label May 17, 2021
IANTHEREAL
IANTHEREAL reviewed May 17, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
@IANTHEREAL
Copy link
Copy Markdown
Contributor

IANTHEREAL commented May 17, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 17, 2021

@IANTHEREAL: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed May 17, 2021
View reviewed changes
Comment thread tidb-binlog/deploy-tidb-binlog.md Outdated
TomShawn
TomShawn reviewed May 17, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
TomShawn
TomShawn reviewed May 17, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label May 19, 2021
@july2993 july2993 removed their request for review June 8, 2021 14:05
@TomShawn TomShawn assigned en-jin19 and unassigned Joyinqin Jul 8, 2021
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d46152e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit e0bf139 into pingcap:master Jul 8, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

In response to a cherrypick label: new pull request created: #6640.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

In response to a cherrypick label: new pull request created: #6641.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

In response to a cherrypick label: new pull request created: #6642.

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 8, 2021
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
binlog: update documents for committs and passoword (#6271) (#6640)
0d52ca9
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
binlog: update documents for committs and passoword (#6271) (#6641)
b53844c
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
binlog: update documents for committs and passoword (#6271) (#6642)
1b8817f
@en-jin19 en-jin19 mentioned this pull request Jul 15, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 15, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@3pointer @3AceShowHand
binlog: update documents for committs and passoword (pingcap#6271)
d48e5d4
This was referenced Jul 27, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@en-jin19 en-jin19

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@3pointer @TomShawn @IANTHEREAL @ti-chi-bot @Joyinqin @en-jin19