Skip to content

Enhance TiDB login descriptions#6371

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
qiancai:enhance-TiDB-login-descriptions-
Jun 1, 2021
Merged

Enhance TiDB login descriptions#6371
ti-chi-bot merged 6 commits into
pingcap:masterfrom
qiancai:enhance-TiDB-login-descriptions-

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented May 31, 2021

What is changed, added or deleted? (Required)

  1. Added a sentence to show that the IP address used to log in to TiDB is the tidb_server address configured in the cluster topology file.
  2. Added a sentence to show that the default password of the root user for the TiDB Dashboard login is empty.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 31, 2021 01:57
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2021
@qiancai qiancai added needs-cherry-pick-release-5.0 translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels May 31, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented May 31, 2021

/cc @lucklove

@ti-chi-bot ti-chi-bot requested a review from lucklove May 31, 2021 01:59
qiancai
qiancai commented May 31, 2021
View reviewed changes
Comment thread post-installation-check.md Outdated
qiancai
qiancai commented May 31, 2021
View reviewed changes
Comment thread post-installation-check.md Outdated
lucklove
lucklove reviewed May 31, 2021
View reviewed changes
Comment thread post-installation-check.md Outdated
@lucklove
Copy link
Copy Markdown
Member

lucklove commented May 31, 2021

REST LGTM

TomShawn
TomShawn approved these changes May 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2021
@qiancai @lucklove
Update post-installation-check.md
26436a5 
Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
qiancai
qiancai commented May 31, 2021
View reviewed changes
Comment thread post-installation-check.md Outdated
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented May 31, 2021

The suggesetion is applied. @lucklove PTAL again, thanks.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 1, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 1, 2021

The suggesetion is applied. @lucklove PTAL again, thanks.

Confirmed with @lucklove, this PR can be merged.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 1, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 1, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d9e819e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2021
@ti-chi-bot ti-chi-bot merged commit beac809 into pingcap:master Jun 1, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 1, 2021

In response to a cherrypick label: new pull request created: #6380.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 1, 2021
@qiancai @ti-chi-bot
Enhance TiDB login descriptions (pingcap#6371)
6c5b287
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 1, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jun 1, 2021
@ti-chi-bot
Enhance TiDB login descriptions (#6371) (#6380)
39b3a8e
@TomShawn TomShawn self-assigned this Jun 30, 2021
@ran-huang ran-huang assigned septemberfd and unassigned TomShawn Sep 9, 2021
@septemberfd septemberfd mentioned this pull request Sep 9, 2021
Merged
12 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 9, 2021
This was referenced Sep 9, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove lucklove left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@septemberfd septemberfd

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qiancai @lucklove @ti-chi-bot @TomShawn @septemberfd @ran-huang