Skip to content

optimizer: modify docs for analyze behavior#6410

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
winoros:analyze-version-2-default
Jun 10, 2021
Merged

optimizer: modify docs for analyze behavior#6410
ti-chi-bot merged 3 commits into
pingcap:masterfrom
winoros:analyze-version-2-default

Conversation

@winoros
Copy link
Copy Markdown
Member

@winoros winoros commented Jun 6, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

We've updated the analyze behavior when setting tidb_analyze_version=2 and change its default value to 2.

This pr is to make the doc compatible with it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@winoros winoros requested review from qw4990 and time-and-fate June 6, 2021 09:14
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2021
@TomShawn TomShawn self-requested a review June 7, 2021 08:53
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. sig/execution Indicates that the Issue or PR belongs to the execution SIG. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. translation/doing This PR’s assignee is translating this PR. v5.1 This PR/issue applies to TiDB v5.1. labels Jun 7, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 7, 2021
time-and-fate
time-and-fate reviewed Jun 8, 2021
View reviewed changes
Comment thread statistics.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jun 8, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2021
time-and-fate
time-and-fate approved these changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 10, 2021

@time-and-fate: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
TomShawn
TomShawn reviewed Jun 10, 2021
View reviewed changes
Comment thread statistics.md Outdated
TomShawn
TomShawn reviewed Jun 10, 2021
View reviewed changes
Comment thread statistics.md Outdated
@winoros @TomShawn
Apply suggestions from code review
94d885e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2021
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jun 10, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 10, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 94d885e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2021
@ti-chi-bot ti-chi-bot merged commit 265a6e8 into pingcap:master Jun 10, 2021
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jun 11, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Jun 11, 2021

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 11, 2021
@winoros winoros mentioned this pull request Jun 22, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. sig/docs Indicates that the Issue or PR belongs to the docs SIG. sig/execution Indicates that the Issue or PR belongs to the execution SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@winoros @ti-chi-bot @TomShawn @Liuxiaozhen12 @time-and-fate