Skip to content

Update complex-cdc.yaml#6465

Merged
ti-chi-bot merged 1 commit into
release-5.0from
asddongmen-patch-1
Jul 15, 2021
Merged

Update complex-cdc.yaml#6465
ti-chi-bot merged 1 commit into
release-5.0from
asddongmen-patch-1

Conversation

@asddongmen
Copy link
Copy Markdown
Contributor

@asddongmen asddongmen commented Jun 17, 2021 •
edited by TomShawn
Loading

Add gc-ttl config example in cdc_servers config.
#1961

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@asddongmen
Update complex-cdc.yaml
b997030 
 add gc-ttl in cdc_servers config
@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 17, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 17, 2021 07:30
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2021
@asddongmen asddongmen requested review from Tammyxia and zier-one June 17, 2021 07:30
@TomShawn TomShawn added needs-cherry-pick-master Should cherry pick this PR to master branch. translation/doing This PR’s assignee is translating this PR. labels Jun 17, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 17, 2021
@asddongmen asddongmen requested a review from amyangfei July 6, 2021 07:59
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-5.1 labels Jul 14, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021
TomShawn
TomShawn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-5.1 labels Jul 15, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 15, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b997030

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@ti-chi-bot ti-chi-bot merged commit 122a44c into release-5.0 Jul 15, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 15, 2021

In response to a cherrypick label: new pull request created: #6676.

@TomShawn TomShawn deleted the asddongmen-patch-1 branch July 15, 2021 08:34
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 15, 2021

In response to a cherrypick label: new pull request created: #6677.

ti-chi-bot added a commit that referenced this pull request Jul 15, 2021
@ti-chi-bot
Update complex-cdc.yaml (#6465) (#6677)
1af944e
ti-chi-bot added a commit that referenced this pull request Jul 15, 2021
@ti-chi-bot
Update complex-cdc.yaml (#6465) (#6676)
5d3bbc0
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@ti-chi-bot @3AceShowHand
Update complex-cdc.yaml (pingcap#6465) (pingcap#6676)
49a98e3
@TomShawn TomShawn assigned hfxsd and unassigned Liuxiaozhen12 Aug 2, 2021
@hfxsd hfxsd mentioned this pull request Aug 4, 2021
Closed
12 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 4, 2021
This was referenced Aug 4, 2021
Closed
Closed
Merged
This was referenced Aug 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zier-one zier-one Awaiting requested review from zier-one

@Tammyxia Tammyxia Awaiting requested review from Tammyxia

2 more reviewers

@amyangfei amyangfei amyangfei approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hfxsd hfxsd

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@asddongmen @ti-chi-bot @TomShawn @amyangfei @hfxsd @Liuxiaozhen12