Skip to content

lightning: fix a lightning config bug#6484

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
glorv:fix-lightning
Jun 22, 2021
Merged

lightning: fix a lightning config bug#6484
ti-chi-bot merged 1 commit into
pingcap:masterfrom
glorv:fix-lightning

Conversation

@glorv
Copy link
Copy Markdown
Contributor

@glorv glorv commented Jun 22, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 22, 2021 07:29
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

@kennytm: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 22, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@kennytm kennytm added missing-translation-status This PR does not have translation status info. and removed needs-cherry-pick-release-4.0 status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR’s assignee is translating this PR. labels Jun 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 22, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8ff4070

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@ti-chi-bot ti-chi-bot merged commit 74b1b03 into pingcap:master Jun 22, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

In response to a cherrypick label: new pull request created: #6486.

@kennytm kennytm added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

In response to a cherrypick label: new pull request created: #6487.

This was referenced Jun 22, 2021
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

In response to a cherrypick label: new pull request created: #6488.

ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
lightning: fix a lightning config bug (#6484) (#6486)
db3166d
ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
lightning: fix a lightning config bug (#6484) (#6487)
444d169
ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
lightning: fix a lightning config bug (#6484) (#6488)
36f0609
@glorv glorv deleted the fix-lightning branch June 22, 2021 08:01
@Joyinqin Joyinqin mentioned this pull request Jun 22, 2021
Merged
12 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Jun 22, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 22, 2021
This was referenced Jun 24, 2021
Merged
Merged
Merged
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@glorv @3AceShowHand
lightning: fix a lightning config bug (pingcap#6484)
956841a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@glorv @ti-chi-bot @TomShawn @Joyinqin @kennytm