add notice about scaling in pd node by AstroProfundis · Pull Request #6514 · pingcap/docs-cn

AstroProfundis · 2021-06-23T11:42:17Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Add a notice about scaling PD nodes, this is the same as in "scale tidb cluster with Ansible" document.

Which TiDB version(s) do your changes apply to? (Required)

master (the latest development version)
v5.1 (TiDB 5.1 versions)
v5.0 (TiDB 5.0 versions)
v4.0 (TiDB 4.0 versions) version specific for 4.0.3
v3.1 (TiDB 3.1 versions)
v3.0 (TiDB 3.0 versions)
v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): TiKV may fail to find PD cluster if all PD members are changed tikv/tikv#4319

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

lilyjazz · 2021-07-01T10:45:10Z


+> **注意：**
+>
+> TiKV 中的 PD Client 会缓存 PD 节点列表，但目前不会定期自动更新，只有在 PD leader 发生切换或 TiKV 重启加载最新配置后才会更新；为避免 TiKV 缓存的 PD 节点列表过旧的风险，在扩缩容 PD 完成后，PD 集群中应至少包含两个扩缩容操作前就已经存在的 PD 节点成员，如果不满足该条件需要手动执行 PD transfer leader 操作，更新 TiKV 中的 PD 缓存列表。


@rleungx 为什么「在扩缩容完成后，至少包含 2 个扩缩容操作前就已经存在的 PD 节点成员」啊～我看这篇文档的示例中，PD 就只有 1 个节点。会不会造成误解？

/cc @AstroProfundis BTW, we need to specify the version of this warning.

What would be the version affected?

Almost all versions before v.4.0.3 and we introduce a new mechanism to reduce the probability after v4.0.3

TomShawn · 2021-07-15T08:59:12Z

/rebase

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot · 2021-07-15T10:07:39Z

@rleungx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn

LGTM

ti-chi-bot · 2021-07-15T10:09:50Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

TomShawn · 2021-07-15T10:10:00Z

/remove-status LGT1
/status LGT2

TomShawn · 2021-07-15T10:10:04Z

/merge

ti-chi-bot · 2021-07-15T10:10:06Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: ee0ea37

ti-chi-bot · 2021-07-15T10:12:12Z

In response to a cherrypick label: new pull request created: #6678.

ti-chi-bot · 2021-07-15T10:12:50Z

In response to a cherrypick label: new pull request created: #6679.

ti-chi-bot · 2021-07-15T10:13:28Z

In response to a cherrypick label: new pull request created: #6680.

AstroProfundis added needs-cherry-pick-release-4.0 labels Jun 23, 2021

AstroProfundis requested a review from rleungx June 23, 2021 11:42

AstroProfundis self-assigned this Jun 23, 2021

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2021

TomShawn added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 24, 2021

TomShawn self-requested a review June 24, 2021 03:01

lilyjazz reviewed Jul 1, 2021

View reviewed changes

TomShawn added the status/require-change Needs the author to address comments. label Jul 5, 2021

TomShawn requested a review from lilyjazz July 6, 2021 05:07

TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Jul 6, 2021

TomShawn reviewed Jul 7, 2021

View reviewed changes

Comment thread scale-tidb-using-tiup.md Outdated

TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-release-4.0 labels Jul 14, 2021

AstroProfundis and others added 3 commits July 15, 2021 09:00

add notice about scaling in pd node

80e0e0a

add version notes

aa32892

Update scale-tidb-using-tiup.md

13e6b0f

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

github-actions Bot force-pushed the pd-scale branch from e1d5dd3 to 13e6b0f Compare July 15, 2021 09:00

TomShawn added needs-cherry-pick-release-4.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Jul 15, 2021

rleungx reviewed Jul 15, 2021

View reviewed changes

Comment thread scale-tidb-using-tiup.md Outdated

Update scale-tidb-using-tiup.md

ee0ea37

Co-authored-by: Ryan Leung <rleungx@gmail.com>

rleungx approved these changes Jul 15, 2021

View reviewed changes

TomShawn approved these changes Jul 15, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021

ti-chi-bot merged commit 4b19b9a into pingcap:master Jul 15, 2021

ti-chi-bot mentioned this pull request Jul 15, 2021

add notice about scaling in pd node (#6514) #6678

Merged

12 tasks

ti-chi-bot mentioned this pull request Jul 15, 2021

add notice about scaling in pd node (#6514) #6679

Merged

12 tasks

ti-chi-bot mentioned this pull request Jul 15, 2021

add notice about scaling in pd node (#6514) #6680

Merged

12 tasks

ti-chi-bot added a commit that referenced this pull request Jul 15, 2021

add notice about scaling in pd node (#6514) (#6680)

6d31f41

ti-chi-bot added a commit that referenced this pull request Jul 15, 2021

add notice about scaling in pd node (#6514) (#6679)

2980557

ti-chi-bot added a commit that referenced this pull request Jul 15, 2021

add notice about scaling in pd node (#6514) (#6678)

317ab33

3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021

add notice about scaling in pd node (pingcap#6514)

aa3d413

Liuxiaozhen12 mentioned this pull request Aug 4, 2021

add notice about scaling in pd node pingcap/docs#6099

Merged

11 tasks

Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 4, 2021

This was referenced Aug 23, 2021

add notice about scaling in pd node (#6099) pingcap/docs#6219

Merged

add notice about scaling in pd node (#6099) pingcap/docs#6220

Merged

add notice about scaling in pd node (#6099) pingcap/docs#6221

Merged

Conversation

AstroProfundis commented Jun 23, 2021 • edited by TomShawn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

lilyjazz Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

rleungx Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

AstroProfundis Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

rleungx Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomShawn commented Jul 15, 2021

Uh oh!

Uh oh!

ti-chi-bot commented Jul 15, 2021

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Jul 15, 2021

Uh oh!

TomShawn commented Jul 15, 2021

Uh oh!

TomShawn commented Jul 15, 2021

Uh oh!

ti-chi-bot commented Jul 15, 2021

Uh oh!

ti-chi-bot commented Jul 15, 2021

Uh oh!

ti-chi-bot commented Jul 15, 2021

Uh oh!

ti-chi-bot commented Jul 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AstroProfundis commented Jun 23, 2021 •

edited by TomShawn

Loading