Skip to content

Add note about stale read#6518

Merged
ti-chi-bot merged 9 commits into
pingcap:masterfrom
NingLin-P:note-stale-read
Jun 24, 2021
Merged

Add note about stale read#6518
ti-chi-bot merged 9 commits into
pingcap:masterfrom
NingLin-P:note-stale-read

Conversation

@NingLin-P
Copy link
Copy Markdown
Contributor

@NingLin-P NingLin-P commented Jun 24, 2021

Signed-off-by: linning linningde25@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@NingLin-P
add note about stale read
fb14ec8 
Signed-off-by: linning <linningde25@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 24, 2021 06:30
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2021
@NingLin-P NingLin-P requested review from Yisaer and nolouch June 24, 2021 06:31
@TomShawn TomShawn added needs-cherry-pick-release-5.1 translation/doing This PR’s assignee is translating this PR. v5.1 This PR/issue applies to TiDB v5.1. labels Jun 24, 2021
nolouch
nolouch reviewed Jun 24, 2021
View reviewed changes
Comment thread as-of-timestamp.md Outdated
NingLin-P and others added 4 commits June 24, 2021 14:36
@NingLin-P
fix lint
1dd6f8c 
Signed-off-by: linning <linningde25@gmail.com>
@nolouch
Update as-of-timestamp.md
21dfe04 
Co-authored-by: ShuNing <nolouch@gmail.com>
@NingLin-P
update
d887647 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P
merge
d473f92 
Signed-off-by: linning <linningde25@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2021
nolouch
nolouch approved these changes Jun 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Copy Markdown
Member

nolouch commented Jun 24, 2021

PTAL @TomShawn

TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
Comment thread as-of-timestamp.md Outdated
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
Comment thread as-of-timestamp.md Outdated
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
Comment thread as-of-timestamp.md Outdated
NingLin-P and others added 3 commits June 24, 2021 17:49
@TomShawn
Update as-of-timestamp.md
3bd97b9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update as-of-timestamp.md
8cda20a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Update as-of-timestamp.md
bdda99e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Jun 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

@TomShawn: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 24, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bdda99e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@TomShawn TomShawn assigned TomShawn and unassigned CharLotteiu Jun 24, 2021
@ti-chi-bot ti-chi-bot merged commit a16f272 into pingcap:master Jun 24, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 24, 2021
@ti-chi-bot
Add note about stale read (pingcap#6518)
bb6b1af
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

In response to a cherrypick label: new pull request created: #6523.

@TomShawn TomShawn mentioned this pull request Jun 24, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
Add note about stale read (#6518) (#6523)
66332a7
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR’s assignee is translating this PR. labels Jun 24, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
11 tasks
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@3AceShowHand
Add note about stale read (pingcap#6518)
e9247cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NingLin-P @ti-chi-bot @nolouch @TomShawn @CharLotteiu