Skip to content

system-variables: ensure alphabetical order#6533

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
Liuxiaozhen12:fix-sysvar-order
Jun 28, 2021
Merged

system-variables: ensure alphabetical order#6533
ti-chi-bot merged 1 commit into
pingcap:masterfrom
Liuxiaozhen12:fix-sysvar-order

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

The system variables are not in alphabetical order. This is useful for users when a list is long because it makes it easier to search for them.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 25, 2021 07:03
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

/label version-specific-changes-required
/translation from-docs
/label v5.1
/label needs-cherry-pick-release-5.0

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. v5.1 This PR/issue applies to TiDB v5.1. needs-cherry-pick-release-5.0 and removed missing-translation-status This PR does not have translation status info. labels Jun 25, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@Liuxiaozhen12: The label(s) version-specific-changes-required cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v5.1, for-future-release, requires-version-specific-changes, website.

Details

In response to this:

/label version-specific-changes-required
/translation from-docs
/label v5.1
/label needs-cherry-pick-release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

@Liuxiaozhen12: The label(s) requires-version-specific-change cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v5.1, for-future-release, requires-version-specific-changes, website.

Details

In response to this:

/label requires-version-specific-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@pingcap pingcap deleted a comment from ti-chi-bot Jun 25, 2021
@Liuxiaozhen12 Liuxiaozhen12 added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed v5.1 This PR/issue applies to TiDB v5.1. labels Jun 25, 2021
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 28, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 55565e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2021
@ti-chi-bot ti-chi-bot merged commit 36fc969 into pingcap:master Jun 28, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 28, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6544.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6545.

3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants