Skip to content

lightning: remove default backend setting from the configuration#6534

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
sleepymole:lightning-backend
Aug 10, 2021
Merged

lightning: remove default backend setting from the configuration#6534
ti-chi-bot merged 1 commit into
pingcap:masterfrom
sleepymole:lightning-backend

Conversation

@sleepymole
Copy link
Copy Markdown
Contributor

@sleepymole sleepymole commented Jun 25, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Remove default backend setting from the configuration and move local backend to the first.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 25, 2021 07:27
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2021
@sleepymole sleepymole requested review from glorv and kennytm June 25, 2021 07:28
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 25, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 25, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 25, 2021

@gozssky Please fix the CI lint and specify the applicable version(s). Thanks~

@glorv
Copy link
Copy Markdown
Contributor

glorv commented Jun 25, 2021

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 28, 2021 •
edited
Loading

@gozssky @glorv Is this PR content applicable only to the dev version?

@sleepymole
Copy link
Copy Markdown
Contributor Author

sleepymole commented Jun 28, 2021

@gozssky @glorv Is this PR content applicable only to the dev version?

I think this is applicable only to the dev version. What do you think? @glorv @kennytm

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Jun 28, 2021

@TomShawn yes, it is only available on dev version (and will be carried to 5.2 and 6.0)

@TomShawn TomShawn added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Jun 28, 2021
@TomShawn TomShawn assigned en-jin19 and unassigned Joyinqin Jul 8, 2021
@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 14, 2021
@TomShawn TomShawn added v5.2 This PR/issue applies to TiDB v5.2. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Aug 5, 2021
TomShawn
TomShawn approved these changes Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
TomShawn
TomShawn reviewed Aug 10, 2021
View reviewed changes
Comment thread tidb-lightning/tidb-lightning-backends.md

+ [Importer-backend](#tidb-lightning-importer-backend)（默认）
+ [Local-backend](#tidb-lightning-local-backend)
+ [Importer-backend](#tidb-lightning-importer-backend)
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Aug 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gozssky @kennytm 所以 TiDB Lightning 没有默认的 backend 了吗？

Copy link
Copy Markdown
Contributor

@kennytm kennytm Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn yes

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 10, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 10, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ca8fefc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2021
@ti-chi-bot ti-chi-bot merged commit 551560c into pingcap:master Aug 10, 2021
@sleepymole sleepymole deleted the lightning-backend branch August 10, 2021 10:03
@en-jin19 en-jin19 mentioned this pull request Aug 10, 2021
Merged
10 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv Awaiting requested review from glorv

@kennytm kennytm Awaiting requested review from kennytm

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@en-jin19 en-jin19

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.2 This PR/issue applies to TiDB v5.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sleepymole @ti-chi-bot @TomShawn @glorv @kennytm @Joyinqin @en-jin19