Skip to content

Not support to set Tombstone#6549

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
HunDunDM:not-support-set-tombstone
Jun 28, 2021
Merged

Not support to set Tombstone#6549
ti-chi-bot merged 1 commit into
pingcap:masterfrom
HunDunDM:not-support-set-tombstone

Conversation

@HunDunDM
Copy link
Copy Markdown
Contributor

@HunDunDM HunDunDM commented Jun 28, 2021

Signed-off-by: HunDunDM hundundm@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Remove the content related to setting Tombstone, they are no longer supported.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: pd#3407
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@HunDunDM
Not support to set Tombstone
14c15d2 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 28, 2021 11:50
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2021
@TomShawn TomShawn requested a review from lucklove June 28, 2021 11:50
@TomShawn TomShawn added needs-cherry-pick-release-5.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. translation/doing This PR’s assignee is translating this PR. labels Jun 28, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 28, 2021
nolouch
nolouch approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 28, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 14c15d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2021
@ti-chi-bot ti-chi-bot merged commit e4dd4b4 into pingcap:master Jun 28, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

In response to a cherrypick label: new pull request created: #6550.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 28, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

In response to a cherrypick label: new pull request created: #6551.

ti-chi-bot added a commit that referenced this pull request Jun 28, 2021
@ti-chi-bot
Not support to set Tombstone (#6549) (#6551)
f866417
ti-chi-bot added a commit that referenced this pull request Jun 28, 2021
@ti-chi-bot
Not support to set Tombstone (#6549) (#6550)
71474dc
@HunDunDM HunDunDM deleted the not-support-set-tombstone branch June 28, 2021 12:07
@Joyinqin Joyinqin mentioned this pull request Jun 29, 2021
Merged
12 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Jun 29, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 29, 2021
This was referenced Jun 29, 2021
Merged
Merged
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@HunDunDM @3AceShowHand
Not support to set Tombstone (pingcap#6549)
081b968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@lucklove lucklove Awaiting requested review from lucklove

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HunDunDM @ti-chi-bot @TomShawn @Joyinqin @nolouch