Skip to content

Update the related variable description for CREATE INDEX#6588

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
qiancai:update_related_variable_info_for_CREATE-INDEX
Jul 5, 2021
Merged

Update the related variable description for CREATE INDEX#6588
ti-chi-bot merged 2 commits into
pingcap:masterfrom
qiancai:update_related_variable_info_for_CREATE-INDEX

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Jul 5, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Update the related variable description for CREATE INDEX because the scope of tidb_ddl_reorg_priority is SESSION instead of GLOBAL.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-3.1 labels Jul 5, 2021
@qiancai qiancai requested a review from tangenta July 5, 2021 03:41
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Jul 5, 2021

/assign

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
TomShawn
TomShawn reviewed Jul 5, 2021
View reviewed changes
Comment thread sql-statements/sql-statement-create-index.md Outdated
TomShawn
TomShawn approved these changes Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2021
@qiancai @TomShawn
Update sql-statements/sql-statement-create-index.md
5233c54 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Jul 5, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5233c54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ti-chi-bot ti-chi-bot merged commit db07f00 into pingcap:master Jul 5, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6605.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 5, 2021
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#6588
b9fc092 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6606.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 5, 2021
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#6588
a4af937 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6607.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6608.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 5, 2021
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#6588
e196421 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6609.

ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Update the related variable description for CREATE INDEX (#6588) (#6605)
749eda7
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Update the related variable description for CREATE INDEX (#6588) (#6609)
29c90d1
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Update the related variable description for CREATE INDEX (#6588) (#6608)
4ba4e25
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Update the related variable description for CREATE INDEX (#6588) (#6606)
cea965c
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
Update the related variable description for CREATE INDEX (#6588) (#6607)
d7be13a
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@qiancai @3AceShowHand
Update the related variable description for CREATE INDEX (pingcap#6588)
c721e93
@TomShawn TomShawn assigned shichun-0415 and unassigned qiancai Sep 8, 2021
@shichun-0415 shichun-0415 mentioned this pull request Sep 9, 2021
Merged
13 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 9, 2021
This was referenced Sep 14, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shichun-0415 shichun-0415

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qiancai @ti-chi-bot @tangenta @TomShawn @shichun-0415