Skip to content

tiup: add notice about importing cluster that don't have all nodes mo…#6659

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
AstroProfundis:add-import-monitor-notice
Jul 16, 2021
Merged

tiup: add notice about importing cluster that don't have all nodes mo…#6659
ti-chi-bot merged 2 commits into
pingcap:masterfrom
AstroProfundis:add-import-monitor-notice

Conversation

@AstroProfundis
Copy link
Copy Markdown
Contributor

@AstroProfundis AstroProfundis commented Jul 12, 2021

…nitored

First-time contributors' checklist

What is changed, added or deleted? (Required)

Some clusters deployed by TiDB-Ansible may not having monitoring agents deployed on all nodes, and if the user imported the cluster with TiUP Cluster, future operations may fail.

This PR adds a notice to the import doc to guide the user to deploy monitoring agents to all nodes before importing to TiUP Cluster.

This PR changes the manual page of tiup cluster import subcommand, I'll file another PR to change the import guidance doc in the release-4.0 branch.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@AstroProfundis AstroProfundis requested a review from lucklove July 12, 2021 07:51
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2021
@AstroProfundis AstroProfundis mentioned this pull request Jul 12, 2021
Merged
12 tasks
@TomShawn TomShawn added needs-cherry-pick-release-4.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. translation/doing This PR’s assignee is translating this PR. labels Jul 12, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 12, 2021
@TomShawn TomShawn added the type/enhancement The issue or PR belongs to an enhancement. label Jul 14, 2021
TomShawn
TomShawn reviewed Jul 16, 2021
View reviewed changes
Comment thread tiup/tiup-component-cluster-import.md Outdated
TomShawn
TomShawn approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This is also approved by @lucklove.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 16, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0bc6825

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@ti-chi-bot ti-chi-bot merged commit 0d97c96 into pingcap:master Jul 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

In response to a cherrypick label: new pull request created: #6691.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

In response to a cherrypick label: new pull request created: #6692.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 16, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

In response to a cherrypick label: new pull request created: #6693.

ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
tiup: add notice about importing cluster that don't have all nodes mo… (
757cdbb 
#6659) (#6691)
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
tiup: add notice about importing cluster that don't have all nodes mo… (
02d084d 
#6659) (#6692)
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
@ti-chi-bot
tiup: add notice about importing cluster that don't have all nodes mo… (
b9db138 
#6659) (#6693)
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@AstroProfundis @3AceShowHand
tiup: add notice about importing cluster that don't have all nodes mo… (
8b6d472 
pingcap#6659)
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 5, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 5, 2021
This was referenced Aug 27, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove Awaiting requested review from lucklove

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AstroProfundis @ti-chi-bot @TomShawn @Liuxiaozhen12