Skip to content

update max-replicas description#6669

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
disksing:max-replicas
Jul 16, 2021
Merged

update max-replicas description#6669
ti-chi-bot merged 2 commits into
pingcap:masterfrom
disksing:max-replicas

Conversation

@disksing
Copy link
Copy Markdown
Contributor

@disksing disksing commented Jul 14, 2021 •
edited by TomShawn
Loading

Signed-off-by: disksing i@disksing.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Make description of max-replcias more specific.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@disksing
update max-replicas description
56f1664 
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 14, 2021 09:29
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2021
@disksing disksing mentioned this pull request Jul 14, 2021
Merged
12 tasks
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
Comment thread pd-configuration-file.md Outdated
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 15, 2021
@TomShawn TomShawn mentioned this pull request Jul 15, 2021
Closed
@TomShawn TomShawn assigned disksing and unassigned en-jin19 Jul 15, 2021
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. require-LGT1 Indicates that the PR requires an LGTM. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 15, 2021
TomShawn
TomShawn approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 96f4285

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@ti-chi-bot ti-chi-bot merged commit ec72df9 into pingcap:master Jul 16, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@disksing @3AceShowHand
update max-replicas description (pingcap#6669)
e1e27ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@disksing disksing

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@disksing @ti-chi-bot @TomShawn @en-jin19