Skip to content

cdc: add compatibility notes for sort-dir (#6648)#6682

Merged
ti-chi-bot merged 7 commits into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-6648-to-release-5.0
Jul 15, 2021
Merged

cdc: add compatibility notes for sort-dir (#6648)#6682
ti-chi-bot merged 7 commits into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-6648-to-release-5.0

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Jul 15, 2021

This is an automated cherry-pick of #6648

What is changed, added or deleted? (Required)

  • Added compatibility notes for sort-dir and data-dir in TiCDC

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. type/enhancement The issue or PR belongs to an enhancement. labels Jul 15, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 15, 2021 11:16
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
Comment thread ticdc/ticdc-overview.md Outdated
@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Jul 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 15, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Jul 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 767766f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@ti-chi-bot ti-chi-bot merged commit b0378ab into pingcap:release-5.0 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liuzix liuzix

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @TomShawn @liuzix