Skip to content

remove useless variable.#6703

Merged
ti-chi-bot merged 1 commit into
masterfrom
LittleFall-patch-1
Jul 20, 2021
Merged

remove useless variable.#6703
ti-chi-bot merged 1 commit into
masterfrom
LittleFall-patch-1

Conversation

@LittleFall
Copy link
Copy Markdown
Contributor

@LittleFall LittleFall commented Jul 20, 2021 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

This variable is deprecated and useless when mpp is enabled, but may confuse users, so I remove it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 20, 2021 06:15
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2021
@LittleFall
Copy link
Copy Markdown
Contributor Author

LittleFall commented Jul 20, 2021

/cc @windtalker

@ti-chi-bot ti-chi-bot requested a review from windtalker July 20, 2021 06:17
@LittleFall LittleFall mentioned this pull request Jul 20, 2021
Merged
11 tasks
@LittleFall
Copy link
Copy Markdown
Contributor Author

LittleFall commented Jul 20, 2021

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun July 20, 2021 06:25
tisonkun
tisonkun reviewed Jul 20, 2021
View reviewed changes
Copy link
Copy Markdown

@tisonkun tisonkun left a comment •
edited by LittleFall
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LittleFall could you refer to the issue in description or comment where we drop bcj for MPP?

windtalker
windtalker approved these changes Jul 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 20, 2021

@windtalker: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall
Copy link
Copy Markdown
Contributor Author

LittleFall commented Jul 20, 2021

@LittleFall could you refer to the issue in description or comment where we drop bcj for MPP?

yeah, according to https://github.com/pingcap/tidb/blob/v5.0.0/planner/core/exhaust_physical_plans.go#L1662-L1679, when mpp is allowed, we will never use old BCJ.

tisonkun
tisonkun approved these changes Jul 20, 2021
View reviewed changes
Copy link
Copy Markdown

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 20, 2021

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.1 require-LGT1 Indicates that the PR requires an LGTM. translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. labels Jul 20, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 20, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 20, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 20, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3109825

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@ti-chi-bot ti-chi-bot merged commit dd0b356 into master Jul 20, 2021
@TomShawn TomShawn deleted the LittleFall-patch-1 branch July 20, 2021 11:53
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 20, 2021

In response to a cherrypick label: new pull request created: #6707.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 20, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 21, 2021
@ti-chi-bot
remove useless variable. (#6703) (#6707)
b3d98c1
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@LittleFall @3AceShowHand
remove useless variable. (pingcap#6703)
b6bbfd1
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 2, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 2, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+2 more reviewers

@tisonkun tisonkun tisonkun approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LittleFall @ti-chi-bot @TomShawn @windtalker @tisonkun @Liuxiaozhen12