Skip to content

mpp: remove outdated tune advise#6705

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
hanfei1991:hanfei/change-tune-advice
Aug 9, 2021
Merged

mpp: remove outdated tune advise#6705
ti-chi-bot merged 1 commit into
pingcap:masterfrom
hanfei1991:hanfei/change-tune-advice

Conversation

@hanfei1991
Copy link
Copy Markdown
Member

@hanfei1991 hanfei1991 commented Jul 20, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

remove a tiflash tuning advise. Right now we have supported tidb_enforce_mpp = ON, so we don't need other way to enforce mpp functions.
Additionally, this tune advise will not take effect any more.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions) Since 5.1.x?
  • v5.0 (TiDB 5.0 versions) Since v5.0.4
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 20, 2021 06:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2021
@hanfei1991 hanfei1991 changed the title mpp: remote outdated tune advise mpp: remove outdated tune advise Jul 20, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Jul 20, 2021
zanmato1984
zanmato1984 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 26, 2021

@zanmato1984: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ilovesoup
ilovesoup approved these changes Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 9, 2021

@ilovesoup: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 9, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f9e516c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-chi-bot ti-chi-bot merged commit 6458b4e into pingcap:master Aug 9, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 9, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 9, 2021

In response to a cherrypick label: new pull request created: #6827.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 9, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 9, 2021

In response to a cherrypick label: new pull request created: #6828.

@TomShawn TomShawn removed the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Aug 9, 2021
ti-chi-bot added a commit that referenced this pull request Aug 9, 2021
@ti-chi-bot
mpp: remove outdated tune advise (#6705) (#6828)
697985a
@hanfei1991 hanfei1991 deleted the hanfei/change-tune-advice branch August 9, 2021 07:36
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 10, 2021
Merged
11 tasks
This was referenced Aug 10, 2021
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Sep 27, 2021
@ti-chi-bot
mpp: remove outdated tune advise (#6705) (#6827)
0ba16a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

+2 more reviewers

@ilovesoup ilovesoup ilovesoup approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@en-jin19 en-jin19

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hanfei1991 @ti-chi-bot @TomShawn @zanmato1984 @ilovesoup @en-jin19