Skip to content

deploy-tidb-binlog: make the expression on deployment clearer#6708

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:Tiup-deployTiDB-Binlog
Jul 21, 2021
Merged

deploy-tidb-binlog: make the expression on deployment clearer#6708
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:Tiup-deployTiDB-Binlog

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Jul 21, 2021 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

make the expression on deployment clearer to close #6684.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 21, 2021 02:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2021
@Liuxiaozhen12 Liuxiaozhen12 self-assigned this Jul 21, 2021
@TomShawn TomShawn requested a review from july2993 July 21, 2021 02:53
@Liuxiaozhen12 Liuxiaozhen12 added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels Jul 21, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 21, 2021
@Liuxiaozhen12 Liuxiaozhen12 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 21, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 21, 2021

@july2993: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Jul 21, 2021
View reviewed changes
Comment thread tidb-binlog/deploy-tidb-binlog.md Outdated
TomShawn
TomShawn approved these changes Jul 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 21, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 21, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 21, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b9bd4ee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2021
@ti-chi-bot ti-chi-bot merged commit 97dfb3f into pingcap:master Jul 21, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 21, 2021

In response to a cherrypick label: new pull request created: #6709.

ti-chi-bot added a commit that referenced this pull request Jul 21, 2021
@ti-chi-bot
deploy-tidb-binlog: make the expression on deployment clearer (#6708) (…
5c363f0 
…#6709)
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@Liuxiaozhen12 @3AceShowHand
deploy-tidb-binlog: make the expression on deployment clearer (pingca…
932570b 
…p#6708)
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 2, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 2, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@july2993 july2993 july2993 approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

文件连接有误

4 participants

@Liuxiaozhen12 @ti-chi-bot @TomShawn @july2993