Skip to content

grafana-overview-dashboard: update the monitoring item for CPS#6754

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
qiancai:update_monintoring_items
Jul 30, 2021
Merged

grafana-overview-dashboard: update the monitoring item for CPS#6754
ti-chi-bot merged 1 commit into
pingcap:masterfrom
qiancai:update_monintoring_items

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Jul 28, 2021

What is changed, added or deleted? (Required)

Fixed the issue reported in https://asktug.com/t/topic/95634

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 28, 2021 12:01
@qiancai qiancai requested review from bb7133 and removed request for TomShawn July 28, 2021 12:01
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2021
@qiancai qiancai added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 28, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Jul 28, 2021

@TomShawn I'll deal with the cherry-pick PRs after this PR is merged.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2021
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/bugfix This PR fixes a bug. and removed require-LGT1 Indicates that the PR requires an LGTM. labels Jul 29, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 30, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Jul 30, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 30, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c641eb0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2021
@ti-chi-bot ti-chi-bot merged commit 009350f into pingcap:master Jul 30, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 30, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 30, 2021

In response to a cherrypick label: new pull request created: #6779.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 30, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 30, 2021

In response to a cherrypick label: new pull request created: #6780.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 30, 2021

In response to a cherrypick label: new pull request created: #6781.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 30, 2021
Merged
11 tasks
@qiancai qiancai mentioned this pull request Jul 30, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
grafana-overview-dashboard: update the monitoring item for CPS (#6754) (
ab8a0d7 
#6779)
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
grafana-overview-dashboard: update the monitoring item for CPS (#6754) (
d7a4df1 
#6780)
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
grafana-overview-dashboard: update the monitoring item for CPS (#6754) (
da5b6ff 
#6781)
This was referenced Jul 30, 2021
Merged
Merged
Merged
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 2, 2021

/assign @hfxsd

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 2, 2021

@TomShawn: GitHub didn't allow me to assign the following users: hfxsd.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @hfxsd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Aug 2, 2021
@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 2, 2021
@qiancai qiancai removed the translation/doing This PR’s assignee is translating this PR. label Aug 2, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Aug 2, 2021

@TomShawn The translation of this PR is done. Sorry for missing adding the translation/done label.

@qiancai qiancai self-assigned this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiancai qiancai

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. sig/docs Indicates that the Issue or PR belongs to the docs SIG. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiancai @ti-chi-bot @TomShawn @bb7133