Skip to content

update the "grafana-tidb-dashboard.md"#6782

Merged
ti-chi-bot merged 15 commits into
pingcap:masterfrom
chunleiz:new-branch-chunleiz
Sep 10, 2021
Merged

update the "grafana-tidb-dashboard.md"#6782
ti-chi-bot merged 15 commits into
pingcap:masterfrom
chunleiz:new-branch-chunleiz

Conversation

@chunleiz
Copy link
Copy Markdown
Contributor

@chunleiz chunleiz commented Jul 31, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Some translations have been optimized, the redundant translation of "handshake error OPS" has been deleted, and the translation of "wait duration" has been added

Which TiDB version(s) do your changes apply to? (Required)

dev

Tips for choosing the affected version(s):

CHOOSE MASTER ONLY

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

#5753

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 31, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jul 31, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 31, 2021 06:23
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 31, 2021

Welcome @chunleiz!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2021
@chunleiz
Copy link
Copy Markdown
Contributor Author

chunleiz commented Jul 31, 2021

translation/from-docs-cn

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Aug 2, 2021
TomShawn
TomShawn reviewed Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments~

Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
Comment thread grafana-tidb-dashboard.md Outdated
@TomShawn TomShawn requested a review from breezewish August 2, 2021 03:40
chunleiz and others added 10 commits August 2, 2021 11:45
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
4cdea59 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
0a9ecaf 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
ba2caba 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
dff4567 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
309e029 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
daf4ec7 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
2ace98f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
08b34b7 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
56e23e5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@chunleiz @TomShawn
Update grafana-tidb-dashboard.md
457d8b5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2021
@TomShawn TomShawn self-assigned this Aug 2, 2021
@chunleiz
Copy link
Copy Markdown
Contributor Author

chunleiz commented Aug 4, 2021

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 4, 2021
@chunleiz
Copy link
Copy Markdown
Contributor Author

chunleiz commented Aug 4, 2021

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR’s assignee is translating this PR. label Aug 4, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 4, 2021

@chunleiz This PR is not a piece of translation from a PR in the English doc repo. Instead, it is a document enhancement on the Chinese document. Therefore, this PR is to be translated and we should add translation/doing label.

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 5, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 30, 2021
TomShawn
TomShawn reviewed Aug 30, 2021
View reviewed changes
Comment thread grafana-tidb-dashboard.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 30, 2021

/rebase

@TomShawn TomShawn added sig/diagnosis sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Sep 6, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 10, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 18579ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2021
@ti-chi-bot ti-chi-bot merged commit 05399ec into pingcap:master Sep 10, 2021
@TomShawn TomShawn assigned shichun-0415 and unassigned TomShawn Sep 15, 2021
@shichun-0415 shichun-0415 added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish Awaiting requested review from breezewish

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shichun-0415 shichun-0415

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chunleiz @ti-chi-bot @TomShawn @shichun-0415