Skip to content

security compatibility: update security compatibility with MySQL#6817

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
en-jin19:Security-and-System-update-Security-Compatibility-with-MySQL-
Aug 10, 2021
Merged

security compatibility: update security compatibility with MySQL#6817
ti-chi-bot merged 5 commits into
pingcap:masterfrom
en-jin19:Security-and-System-update-Security-Compatibility-with-MySQL-

Conversation

@en-jin19
Copy link
Copy Markdown
Contributor

@en-jin19 en-jin19 commented Aug 5, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

updated security compatibility with MySQL in "security compatibility with MySQL" and "system variable".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: #5921
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs This PR is translated from a PR in pingcap/docs. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Aug 5, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 6, 2021

@en-jin19 Is this translation finished? In https://github.com/pingcap/docs/pull/5921/files, two docs are updated.

@TomShawn TomShawn added v5.2 This PR/issue applies to TiDB v5.2. requires-followup This PR requires a follow-up task after being merged. labels Aug 6, 2021
@en-jin19 en-jin19 changed the title system variable: update security compatibility with MySQL security compatibility: update security compatibility with MySQL Aug 6, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
TomShawn
TomShawn reviewed Aug 9, 2021
View reviewed changes
Comment thread system-variables.md Outdated
Comment thread security-compatibility-with-mysql.md Outdated
Comment thread system-variables.md Outdated
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Aug 9, 2021
@en-jin19 @TomShawn
Apply suggestions from code review
f94b758 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2021
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 10, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 10, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f94b758

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2021
@ti-chi-bot ti-chi-bot merged commit e14aded into pingcap:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

requires-followup This PR requires a follow-up task after being merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.2 This PR/issue applies to TiDB v5.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@en-jin19 @ti-chi-bot @TomShawn @tiancaiamao