Skip to content

update syncer.to.checkpoint info#6830

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
glkappe:patch-79
Aug 30, 2021
Merged

update syncer.to.checkpoint info#6830
ti-chi-bot merged 6 commits into
pingcap:masterfrom
glkappe:patch-79

Conversation

@glkappe
Copy link
Copy Markdown
Contributor

@glkappe glkappe commented Aug 9, 2021 •
edited by TomShawn
Loading

There is a problem with the type level. It is at the same level as the schema.
Optimize the document structure to make it easier to read

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@glkappe
update syncer.to.checkpoint info
eb37631 
There is a problem with the `type` level. It is at the same level as the schema.
Optimize the document structure to make it easier to read
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 9, 2021 08:02
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2021
@glkappe
Copy link
Copy Markdown
Contributor Author

glkappe commented Aug 9, 2021

cc @TomShawn

@lichunzhu PTAL

@TomShawn TomShawn requested review from july2993 and lichunzhu August 9, 2021 08:34
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Aug 9, 2021
lichunzhu
lichunzhu reviewed Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Aug 10, 2021
glkappe and others added 2 commits August 10, 2021 15:04
@glkappe @lichunzhu
Update tidb-binlog/tidb-binlog-configuration-file.md
6b6263a 
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@glkappe @lichunzhu
Update tidb-binlog/tidb-binlog-configuration-file.md
10fde5c 
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@glkappe
Copy link
Copy Markdown
Contributor Author

glkappe commented Aug 10, 2021

thanks for @lichunzhu

lichunzhu
lichunzhu approved these changes Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2021
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Aug 10, 2021
TomShawn
TomShawn reviewed Aug 10, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
TomShawn
TomShawn reviewed Aug 10, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md
@glkappe @TomShawn
Update tidb-binlog/tidb-binlog-configuration-file.md
c000668 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Aug 30, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
TomShawn
TomShawn reviewed Aug 30, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
TomShawn
TomShawn reviewed Aug 30, 2021
View reviewed changes
Comment thread tidb-binlog/tidb-binlog-configuration-file.md Outdated
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 30, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 30, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 30, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4afd7fd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot ti-chi-bot merged commit 44ca5b4 into pingcap:master Aug 30, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 30, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 30, 2021

In response to a cherrypick label: new pull request created: #7033.

@en-jin19 en-jin19 mentioned this pull request Aug 30, 2021
Merged
12 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 30, 2021
ti-chi-bot added a commit that referenced this pull request Aug 30, 2021
@ti-chi-bot
update syncer.to.checkpoint info (#6830) (#7033)
6b1b3e4
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 31, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@july2993 july2993 Awaiting requested review from july2993

2 more reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@en-jin19 en-jin19

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@glkappe @ti-chi-bot @TomShawn @lichunzhu @en-jin19