Skip to content

partitioning: Corrected partition management#6837

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
Liuxiaozhen12:partitioned-table
Sep 6, 2021
Merged

partitioning: Corrected partition management#6837
ti-chi-bot merged 3 commits into
pingcap:masterfrom
Liuxiaozhen12:partitioned-table

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Aug 11, 2021

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 11, 2021 02:14
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2021
@Liuxiaozhen12 Liuxiaozhen12 added needs-cherry-pick-release-5.0 translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
Liuxiaozhen12
Liuxiaozhen12 commented Aug 27, 2021
View reviewed changes
Comment thread partitioned-table.md Outdated
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 27, 2021
TomShawn
TomShawn reviewed Aug 31, 2021
View reviewed changes
Comment thread partitioned-table.md Outdated
TomShawn
TomShawn reviewed Aug 31, 2021
View reviewed changes
Comment thread partitioned-table.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Aug 31, 2021
@Liuxiaozhen12 @TomShawn
Apply suggestions from code review
b878f40 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed status/require-change Needs the author to address comments. labels Sep 6, 2021
TomShawn
TomShawn approved these changes Sep 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b878f40

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot ti-chi-bot merged commit ef4bb2e into pingcap:master Sep 6, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 6, 2021

In response to a cherrypick label: new pull request created: #7080.

This was referenced Sep 6, 2021
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 6, 2021

In response to a cherrypick label: new pull request created: #7081.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 6, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 6, 2021

In response to a cherrypick label: new pull request created: #7082.

ti-chi-bot added a commit that referenced this pull request Sep 6, 2021
@ti-chi-bot
partitioning: Corrected partition management (#6837) (#7080)
50ffe35
ti-chi-bot added a commit that referenced this pull request Sep 6, 2021
@ti-chi-bot
partitioning: Corrected partition management (#6837) (#7081)
71344e8
ti-chi-bot added a commit that referenced this pull request Sep 6, 2021
@ti-chi-bot
partitioning: Corrected partition management (#6837) (#7082)
b54b96d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Liuxiaozhen12 @ti-chi-bot @TomShawn @tiancaiamao