Skip to content

Update telemetry.md#6841

Closed
lilyjazz wants to merge 1 commit into
pingcap:masterfrom
lilyjazz:patch-9
Closed

Update telemetry.md#6841
lilyjazz wants to merge 1 commit into
pingcap:masterfrom
lilyjazz:patch-9

Conversation

@lilyjazz
Copy link
Copy Markdown
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 11, 2021 02:40
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2021
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. and removed missing-translation-status This PR does not have translation status info. labels Aug 11, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

@leiysky PTAL, thanks!

@TomShawn
Copy link
Copy Markdown
Contributor

/cc @leiysky

@ti-chi-bot
Copy link
Copy Markdown
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: leiysky.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @leiysky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leiysky
Copy link
Copy Markdown
Contributor

leiysky commented Aug 11, 2021

@lilyjazz I thought the description about builtin function usage has been introduced in #6731.

@TomShawn
Copy link
Copy Markdown
Contributor

@lilyjazz I thought the description about builtin function usage has been introduced in #6731.

@lilyjazz Shall we close this PR?

@lilyjazz
Copy link
Copy Markdown
Member Author

@lilyjazz I thought the description about builtin function usage has been introduced in #6731.

ok, I agree with you.

@lilyjazz lilyjazz closed this Aug 12, 2021
@TomShawn TomShawn removed status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR’s assignee is translating this PR. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. v5.2 This PR/issue applies to TiDB v5.2. labels Aug 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. missing-translation-status This PR does not have translation status info. labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants