Skip to content

fix the description about the slow score range of slow stores#6871

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
5kbpers:slow-store
Aug 17, 2021
Merged

fix the description about the slow score range of slow stores#6871
ti-chi-bot merged 5 commits into
pingcap:masterfrom
5kbpers:slow-store

Conversation

@5kbpers
Copy link
Copy Markdown
Contributor

@5kbpers 5kbpers commented Aug 16, 2021

Signed-off-by: 5kbpers tangminghua@pingcap.com

What is changed, added or deleted? (Required)

fix the description about the slow score range of slow stores

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

fix the description about slow score range
813e7dd 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 16, 2021 09:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021

@rleungx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 813e7dd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 16, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
TomShawn
TomShawn reviewed Aug 16, 2021
View reviewed changes
Comment thread best-practices/pd-scheduling-best-practices.md Outdated
实践中，如果能确定这个节点的故障是不可恢复的，可以立即做下线处理，这样 PD 能尽快补齐副本，降低数据丢失的风险。与之相对，如果确定这个节点是能恢复的，但可能半小时之内来不及，则可以把 `max-store-down-time` 临时调整为比较大的值，这样能避免超时之后产生不必要的副本补充，造成资源浪费。

自 v5.2.0 起，TiKV 引入了慢节点检测机制。通过对 TiKV 中的请求进行采样，计算出一个范围在 1~100 的分数。当分数大于 80 时，该节点会被设置为 Slow 状态。可以通过添加 `evict-slow-store-scheduler` 来针对慢节点进行对应的检测和调度，目前支持当且仅当出现一个慢节点时，将慢节点上的 leader 全部驱逐（其作用类似于 `evict-leader-scheduler`）。
自 v5.2.0 起，TiKV 引入了慢节点检测机制。通过对 TiKV 中的请求进行采样，计算出一个范围在 1~100 的分数。当分数大于等于 80 时，该节点会被设置为 Slow 状态。可以通过添加 `evict-slow-store-scheduler` 来针对慢节点进行对应的检测和调度，目前支持当且仅当出现一个慢节点时，将慢节点上的 leader 全部驱逐（其作用类似于 `evict-leader-scheduler`）。
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Aug 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搜索了一下，当前文档中没有 evict-slow-store-scheduler 的说明，能否在这个 PR 中补充一下呢？
@5kbpers

Copy link
Copy Markdown
Contributor Author

@5kbpers 5kbpers Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前对于 scheduler 的描述似乎都在这个文档里

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

找到了，能否链到这里呢？https://github.com/pingcap/docs-cn/blob/master/pd-control.md#scheduler-show--add--remove--pause--resume--config

Copy link
Copy Markdown
Contributor Author

@5kbpers 5kbpers Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn 修改了，麻烦再看看

address comment
63a2a3e 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
fix ci lint
292ecba 
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
TomShawn
TomShawn reviewed Aug 16, 2021
View reviewed changes
Comment thread best-practices/pd-scheduling-best-practices.md Outdated
TomShawn
TomShawn reviewed Aug 16, 2021
View reviewed changes
Comment thread pd-control.md Outdated
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 17, 2021
@TomShawn TomShawn mentioned this pull request Aug 17, 2021
Merged
11 tasks
@TomShawn TomShawn added the v5.2 This PR/issue applies to TiDB v5.2. label Aug 17, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 17, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 17, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5c6373b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021
@ti-chi-bot ti-chi-bot merged commit 60b4140 into pingcap:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hfxsd hfxsd

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@5kbpers @ti-chi-bot @TomShawn @rleungx @hfxsd