Reverted: update bcj threshold by hanfei1991 · Pull Request #6875 · pingcap/docs-cn

hanfei1991 · 2021-08-16T12:28:25Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-08-16T12:28:27Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

LittleFall · 2021-08-16T12:32:02Z

- 范围：`[0, 9223372036854775807]`
- 单位为行数。如果 join 的对象为子查询，优化器无法估计子查询结果集大小，在这种情况下通过结果集行数判断。如果子查询的行数估计值小于该变量，则选择 Broadcast Hash Join 算法。否则选择 Shuffled Hash Join 算法。
+- 范围：`[-1, 9223372036854775807]`
+- 单位为行数。如果 join 的对象为子查询，优化器无法估计子查询结果集大小，在这种情况下通过结果集行数判断。如果子查询的行数估计值小于该变量，则选择 Broadcast Hash Join 算法。否则选择 Shuffled Hash Join 算法。当值为 -1 时，默认选择 broadcast_join 算法。


add a ref to https://docs.pingcap.com/zh/tidb/dev/use-tiflash#mpp-%E6%A8%A1%E5%BC%8F%E7%9A%84%E7%AE%97%E6%B3%95%E6%94%AF%E6%8C%81?

LittleFall · 2021-08-16T12:32:32Z

+- 范围：`[-1, 9223372036854775807]`
 - 单位：字节
- 如果表大小（字节数）小于该值，则选择 Broadcast Hash Join 算法。否则选择 Shuffled Hash Join 算法。
+- 如果表大小（字节数）小于该值，则选择 Broadcast Hash Join 算法。否则选择 Shuffled Hash Join 算法。当值为 -1 时，默认选择 broadcast_join 算法。


add tidb_opt_broadcast_cartesian_join

LittleFall

LGTM

ti-chi-bot · 2021-08-16T13:02:30Z

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-08-16T13:20:02Z

@LiSong0214: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn

LGTM

TomShawn · 2021-08-17T06:32:23Z

/remove-status LGT1
/status LGT2

TomShawn · 2021-08-17T06:32:27Z

/merge

ti-chi-bot · 2021-08-17T06:32:30Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: ed0b448

This reverts commit 463cbf4.

update bcj threshold

ffd4793

ti-chi-bot requested a review from TomShawn August 16, 2021 12:28

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2021

LittleFall reviewed Aug 16, 2021

View reviewed changes

update bcj threshold

d95b814

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2021

LittleFall added 2 commits August 16, 2021 20:56

Update system-variables.md

614d52e

Update use-tiflash.md

58d7685

LittleFall approved these changes Aug 16, 2021

View reviewed changes

LiSong0214 approved these changes Aug 16, 2021

View reviewed changes

LiSong0214 mentioned this pull request Aug 16, 2021

planner: refine the control logic of broadcast join pingcap/tidb#26347

Merged

10 tasks

qiancai added the v5.2 This PR/issue applies to TiDB v5.2. label Aug 16, 2021

TomShawn assigned en-jin19 Aug 17, 2021

TomShawn added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 17, 2021

TomShawn reviewed Aug 17, 2021

View reviewed changes

Comment thread system-variables.md Outdated

TomShawn reviewed Aug 17, 2021

View reviewed changes

Comment thread system-variables.md Outdated

TomShawn reviewed Aug 17, 2021

View reviewed changes

Comment thread tiflash/use-tiflash.md Outdated

TomShawn reviewed Aug 17, 2021

View reviewed changes

Comment thread tiflash/use-tiflash.md Outdated

Apply suggestions from code review

ed0b448

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn approved these changes Aug 17, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021

TomShawn merged commit 463cbf4 into pingcap:master Aug 17, 2021

hanfei1991 deleted the hanfei/update-bcj-var branch August 17, 2021 07:31

en-jin19 mentioned this pull request Aug 17, 2021

Reverted: System variables: update broadcast_join_threshold_count and `broadc… pingcap/docs#6181

Merged

12 tasks

en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 17, 2021

TomShawn added a commit that referenced this pull request Aug 24, 2021

Revert "update bcj threshold (#6875)"

5f5fc61

This reverts commit 463cbf4.

TomShawn mentioned this pull request Aug 24, 2021

Revert "update bcj threshold" #6926

Merged

TomShawn changed the title ~~update bcj threshold~~ Reverted: update bcj threshold Aug 24, 2021

Conversation

hanfei1991 commented Aug 16, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Aug 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LittleFall Aug 16, 2021

Choose a reason for hiding this comment

Uh oh!

LittleFall Aug 16, 2021

Choose a reason for hiding this comment

Uh oh!

LittleFall Aug 16, 2021

Choose a reason for hiding this comment

Uh oh!

LittleFall left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Aug 16, 2021

Uh oh!

ti-chi-bot commented Aug 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn commented Aug 17, 2021

Uh oh!

TomShawn commented Aug 17, 2021

Uh oh!

ti-chi-bot commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ti-chi-bot commented Aug 16, 2021 •

edited

Loading