Add description for TiKV Ready handled panel by tabokie · Pull Request #6989 · pingcap/docs-cn

tabokie · 2021-08-26T08:19:44Z

https://asktug.com/t/topic/123305

What is changed, added or deleted? (Required)

Add counter type description for TiKV "Ready handled" panel

Which TiDB version(s) do your changes apply to? (Required)

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
- For v2.1, "v3.0.0 后废弃" can be removed
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-08-26T08:19:45Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

tabokie · 2021-08-26T08:19:59Z

/cc @BusyJay

qiancai · 2021-08-26T09:26:32Z

More information for this PR: This PR is to resolve the feedbacks from https://asktug.com/t/topic/123305

TomShawn · 2021-08-26T11:45:02Z

@tabokie I don't think we need to cherry-pick this to v3.1/v3.0/v2.1 which is beyond the extended support period.

ti-chi-bot · 2021-08-30T04:57:03Z

@BusyJay: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-08-30T07:22:42Z

 - Ready handled：Raft 中不同 ready 类型的 ops
+  - count: 批量处理 ready 的 ops
+  - has_ready_region: 获得 ready 的 region 的 ops
+  - pending_region: 被检查是否获得 ready 的 region 的 ops，v3.0.0 后废弃


这一项是否还存在于面板中呢？

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2021-08-30T08:28:30Z

/merge

ti-chi-bot · 2021-08-30T08:28:32Z

@TomShawn: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-08-30T08:30:45Z

/remove-status LGT1
/status LGT2

TomShawn · 2021-08-30T08:30:49Z

/merge

ti-chi-bot · 2021-08-30T08:30:51Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 5ea1e3f

ti-chi-bot · 2021-08-30T08:42:48Z

In response to a cherrypick label: new pull request created: #7034.

ti-chi-bot · 2021-08-30T08:43:24Z

In response to a cherrypick label: new pull request created: #7035.

ti-chi-bot · 2021-09-06T05:57:16Z

In response to a cherrypick label: new pull request created: #7075.

Add description for TiKV Ready handled panel

66315b6

ti-chi-bot requested a review from TomShawn August 26, 2021 08:19

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2021

ti-chi-bot requested a review from BusyJay August 26, 2021 08:19

TomShawn added the translation/doing This PR’s assignee is translating this PR. label Aug 26, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 26, 2021

TomShawn added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-5.0 labels Aug 26, 2021

TomShawn added the status/PTAL This PR is ready for reviewing. label Aug 30, 2021

BusyJay approved these changes Aug 30, 2021

View reviewed changes

TomShawn reviewed Aug 30, 2021

View reviewed changes

TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Aug 30, 2021

tabokie and others added 2 commits August 30, 2021 16:10

Update grafana-tikv-dashboard.md

2157db8

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update grafana-tikv-dashboard.md

52361ae

TomShawn reviewed Aug 30, 2021

View reviewed changes

Comment thread grafana-tikv-dashboard.md Outdated

Update grafana-tikv-dashboard.md

5ea1e3f

TomShawn approved these changes Aug 30, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2021

TomShawn removed the status/require-change Needs the author to address comments. label Aug 30, 2021

TomShawn assigned Liuxiaozhen12 Aug 30, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 30, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021

ti-chi-bot merged commit 7faf9b7 into pingcap:master Aug 30, 2021

ti-chi-bot mentioned this pull request Aug 30, 2021

Add description for TiKV Ready handled panel (#6989) #7034

Merged

12 tasks

ti-chi-bot mentioned this pull request Aug 30, 2021

Add description for TiKV Ready handled panel (#6989) #7035

Merged

12 tasks

ti-chi-bot added a commit that referenced this pull request Aug 30, 2021

Add description for TiKV Ready handled panel (#6989) (#7035)

b1c28c1

ti-chi-bot added a commit that referenced this pull request Aug 30, 2021

Add description for TiKV Ready handled panel (#6989) (#7034)

0d6942c

Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 2, 2021

TomShawn added the needs-cherry-pick-release-5.2 label Sep 6, 2021

ti-chi-bot mentioned this pull request Sep 6, 2021

Add description for TiKV Ready handled panel (#6989) #7075

Merged

12 tasks

ti-chi-bot added a commit that referenced this pull request Sep 6, 2021

Add description for TiKV Ready handled panel (#6989) (#7075)

945b85b

TomShawn mentioned this pull request Sep 8, 2021

Add description for TiKV Ready handled panel pingcap/docs#6375

Merged

13 tasks

This was referenced Sep 8, 2021

Add description for TiKV Ready handled panel (#6375) pingcap/docs#6407

Merged

Add description for TiKV Ready handled panel (#6375) pingcap/docs#6408

Merged

Add description for TiKV Ready handled panel (#6375) pingcap/docs#6409

Merged

Conversation

tabokie commented Aug 26, 2021

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tabokie commented Aug 26, 2021

Uh oh!

qiancai commented Aug 26, 2021

Uh oh!

TomShawn commented Aug 26, 2021

Uh oh!

ti-chi-bot commented Aug 30, 2021

Uh oh!

Uh oh!

TomShawn Aug 30, 2021

Choose a reason for hiding this comment

Uh oh!

tabokie Aug 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Aug 30, 2021

Uh oh!

ti-chi-bot commented Aug 30, 2021

Uh oh!

TomShawn commented Aug 30, 2021

Uh oh!

TomShawn commented Aug 30, 2021

Uh oh!

ti-chi-bot commented Aug 30, 2021

Uh oh!

ti-chi-bot commented Aug 30, 2021

Uh oh!

ti-chi-bot commented Aug 30, 2021

Uh oh!

ti-chi-bot commented Sep 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ti-chi-bot commented Aug 26, 2021 •

edited

Loading