Skip to content

5.0.1 release notes: add the changes to committer-concurrency#7145

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
qiancai:add_committer-concurrency_changes
Sep 30, 2021
Merged

5.0.1 release notes: add the changes to committer-concurrency#7145
ti-chi-bot merged 3 commits into
pingcap:masterfrom
qiancai:add_committer-concurrency_changes

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Sep 17, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#23776
#7142

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-5.0 labels Sep 17, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 17, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2021
@qiancai qiancai added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
Copy link
Copy Markdown
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

@Little-Wallace: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai qiancai requested a review from TomShawn September 17, 2021 06:17
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Sep 17, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@qiancai: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Sep 17, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2021
Comment thread releases/release-5.0.1.md

TiDB 版本:5.0.1

## 兼容性更改
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这不算兼容性更改吧

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

倾向于放在改进提升里

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前看到的配置项 默认值变更也写到了 release notes 的兼容性变更(例如以下)里。关于默认值变化,目前对应的文档里没写,如果 release notes 也不写,可能用户就无法知道这个变更了。

@qiancai qiancai changed the title 5.0.0 release notes: add the changes to committer-concurrency 5.1.0 release notes: add the changes to committer-concurrency Sep 17, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@youjiali1995: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Sep 17, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@qiancai: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 30, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b944a6b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2021
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #7232.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #7233.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #7234.

TomShawn pushed a commit that referenced this pull request Sep 30, 2021
…#7234)

* Update release-5.0.0.md

* Revert "Update release-5.0.0.md"

This reverts commit 7539cdf.

* Update release-5.0.1.md

Co-authored-by: qiancai <qqzczy@126.com>
@shichun-0415 shichun-0415 changed the title 5.1.0 release notes: add the changes to committer-concurrency 5.0.1 release notes: add the changes to committer-concurrency Oct 12, 2021
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants