Skip to content

performance_schema -> information_schema#7147

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
shichun-0415:performance_schema---information_schema
Sep 24, 2021
Merged

performance_schema -> information_schema#7147
ti-chi-bot merged 2 commits into
pingcap:masterfrom
shichun-0415:performance_schema---information_schema

Conversation

@shichun-0415
Copy link
Copy Markdown
Contributor

@shichun-0415 shichun-0415 commented Sep 17, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Stress that TiDB provides system tables in information_schema, not in performance_schema

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 17, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn September 17, 2021 10:48
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
@shichun-0415 shichun-0415 requested review from Liuxiaozhen12, TomShawn, djshow832, kolbe and morgo and removed request for TomShawn and djshow832 September 17, 2021 10:49
@shichun-0415 shichun-0415 added needs-cherry-pick-release-4.0 translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug. and removed missing-translation-status This PR does not have translation status info. labels Sep 17, 2021
@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Sep 17, 2021

I've finished the self-check of this PR. PTAL. Thanks.

@morgo
Copy link
Copy Markdown

morgo commented Sep 17, 2021

Looks good, but I'm sorry I can't review Chinese :-)

@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Sep 18, 2021

Looks good, but I'm sorry I can't review Chinese :-)

Get it. Please ignore the review request. Thanks :-)

TomShawn
TomShawn reviewed Sep 24, 2021
View reviewed changes
Comment thread statement-summary-tables.md Outdated
TomShawn
TomShawn approved these changes Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 24, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 24, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 24, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a7e191a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2021
@ti-chi-bot ti-chi-bot merged commit 54c9cdc into pingcap:master Sep 24, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 24, 2021

In response to a cherrypick label: new pull request created: #7171.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 24, 2021

In response to a cherrypick label: new pull request created: #7172.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 24, 2021

In response to a cherrypick label: new pull request created: #7173.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 24, 2021

In response to a cherrypick label: new pull request created: #7174.

ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
performance_schema -> information_schema (#7147) (#7174)
7787bc8
ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
performance_schema -> information_schema (#7147) (#7171)
a22c604
ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
performance_schema -> information_schema (#7147) (#7172)
e15806e
ti-chi-bot added a commit that referenced this pull request Sep 26, 2021
@ti-chi-bot
performance_schema -> information_schema (#7147) (#7173)
c3df1df
@shichun-0415 shichun-0415 deleted the performance_schema---information_schema branch November 25, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liuxiaozhen12 Liuxiaozhen12 Awaiting requested review from Liuxiaozhen12

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shichun-0415 @ti-chi-bot @morgo @TomShawn