Skip to content

docs: update TiKV store status information #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 8 commits into from
Oct 12, 2021
Merged

docs: update TiKV store status information #7177

ti-chi-bot merged 8 commits into from
Oct 12, 2021

Conversation

@en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Sep 24, 2021

What is changed, added or deleted? (Required)

updated the TiKV store statues and their detailed relationships to "tidb-scheduling.md" and "pd-control.md".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 24, 2021 15:14
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2021
@en-jin19 en-jin19 removed the request for review from TomShawn September 24, 2021 15:16
@en-jin19 en-jin19 marked this pull request as draft September 24, 2021 15:17
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2021
@en-jin19 en-jin19 added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Sep 24, 2021
@en-jin19 en-jin19 added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. type/enhancement The issue or PR belongs to an enhancement. and removed type/enhancement The issue or PR belongs to an enhancement. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Sep 24, 2021
@en-jin19 en-jin19 changed the title (draft) docs: update TiKV store status information docs: update TiKV store status information Sep 29, 2021
@en-jin19 en-jin19 marked this pull request as ready for review September 29, 2021 13:48
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021
@en-jin19 en-jin19 requested a review from nolouch September 29, 2021 13:49
@TomShawn
Copy link
Contributor

TomShawn commented Sep 29, 2021

/verify

@en-jin19 @TomShawn
Apply suggestions from code review
1e9474a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
nolouch
nolouch reviewed Oct 9, 2021
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@en-jin19 @nolouch
Apply suggestions from code review
140f975 
Co-authored-by: ShuNing <nolouch@gmail.com>
@TomShawn
Copy link
Contributor

TomShawn commented Oct 11, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2021
@en-jin19 en-jin19 assigned en-jin19 and unassigned en-jin19 Oct 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Oct 12, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 140f975

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2021
@ti-chi-bot ti-chi-bot merged commit b8e6959 into pingcap:master Oct 12, 2021
@en-jin19 en-jin19 mentioned this pull request Oct 25, 2021
Merged
12 tasks
@en-jin19 en-jin19 mentioned this pull request Nov 23, 2021
Merged
14 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 23, 2021
This was referenced Mar 24, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 31, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@en-jin19 en-jin19

Labels

area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@en-jin19 @ti-chi-bot @TomShawn @nolouch