update SPM doc for SQL plan auto capture #8619

Reminiscent · 2022-03-10T11:23:06Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-03-10T11:23:07Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

qiancai
shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Reminiscent · 2022-03-10T11:23:40Z

/cc @qw4990

sql-plan-management.md

system-variables.md

sql-plan-management.md

shichun-0415 · 2022-03-15T11:08:18Z

sql-plan-management.md

+SET BINDING [ENABLED | DISABLED] FOR BindableStmt;
+```
+
+该语句可以在 GLOBAL 作用域内变更指定的执行计划绑定的状态，作用域不可指定，默认作用域为 GLOBAL。


Suggested change

该语句可以在 GLOBAL 作用域内变更指定的执行计划绑定的状态，作用域不可指定，默认作用域为 GLOBAL。

该语句可以在 GLOBAL 作用域内变更指定执行计划绑定的状态为 `Enabled` 或者 `Disabled`，作用域默认为 GLOBAL，不可指定。

sql-plan-management.md

system-variables.md

sql-plan-management.md

qiancai · 2022-03-21T07:49:20Z

sql-plan-management.md

+| **过滤维度** | **维度名称** | **说明**                                                     | 注意事项                                                     |
+| :----------- | :----------- | :----------------------------------------------------------- | ------------------------------------------------------------ |
+| 表名         | table        | 按照表名进行过滤，每个过滤规则均采用 `db.table` 形式，支持通配符。详细规则可以参考[直接使用表名](/table-filter.md#直接使用表名)和[使用通配符](/table-filter.md#使用通配符)。 | 字母大小写不敏感，如果包含非法内容，日志会输出 `[sql-bind] failed to load mysql.capture_plan_baselines_blacklist` 警告。 |
+| 频率         | frequency    | 默认捕获执行超过一次的语句。可以设置较大值来增加捕获语句的频率。 | 插入的值小于 1 会被认为是非法值，同时，日志会输出 `[sql-bind] frequency threshold is less than 1, ignore it` 警告。如果插入了多条变更频率，频率最大的值会被用作过滤条件。 |


插入了多条指的是 INSERT INTO mysql.capture_plan_baselines_blacklist(filter_type, filter_value) VALUES('frequency', '2'), ('frequency', '3') 这样吗？还是分别执行两次 insert 呢

sql-plan-management.md

Co-authored-by: Grace Cai <qqzczy@126.com>

sql-plan-management.md

Reminiscent · 2022-03-21T08:45:57Z

@qiancai PTAL

sql-plan-management.md

Co-authored-by: Grace Cai <qqzczy@126.com>

qiancai

LGTM

shichun-0415 · 2022-03-22T12:00:52Z

/merge

ti-chi-bot · 2022-03-22T12:00:55Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 28627d7

update SPM doc

ce88a97

ti-chi-bot requested a review from TomShawn March 10, 2022 11:23

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2022

ti-chi-bot requested a review from qw4990 March 10, 2022 11:23

Reminiscent commented Mar 10, 2022

View reviewed changes

sql-plan-management.md Show resolved Hide resolved

TomShawn added the v6.0 This PR/issue applies to TiDB v6.0. label Mar 11, 2022

TomShawn self-assigned this Mar 11, 2022

TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed missing-translation-status This PR does not have translation status info. labels Mar 11, 2022

TomShawn changed the title ~~update SPM doc~~ update SPM doc for SQL plan auto capture Mar 11, 2022

TomShawn added the translation/doing This PR’s assignee is translating this PR. label Mar 11, 2022

TomShawn reviewed Mar 11, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 11, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 11, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 11, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

qw4990 reviewed Mar 11, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn assigned shichun-0415 and unassigned TomShawn Mar 14, 2022

address comments

078889a

TomShawn reviewed Mar 15, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 15, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 15, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 15, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

shichun-0415 reviewed Mar 15, 2022

View reviewed changes

TomShawn reviewed Mar 15, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 15, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 15, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

Reminiscent commented Mar 18, 2022

View reviewed changes

sql-plan-management.md Show resolved Hide resolved

qiancai reviewed Mar 21, 2022

View reviewed changes

Reminiscent and others added 5 commits March 21, 2022 16:37

Update sql-plan-management.md

68024b3

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-plan-management.md

f2c222a

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-plan-management.md

a411d8f

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-plan-management.md

ad5f9de

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-plan-management.md

b34f679

Reminiscent commented Mar 21, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

Update sql-plan-management.md

1ca5cfc

Reminiscent commented Mar 21, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

Reminiscent commented Mar 21, 2022

View reviewed changes

sql-plan-management.md Show resolved Hide resolved

Reminiscent added 2 commits March 21, 2022 17:01

Update sql-plan-management.md

f3f6e22

Update sql-plan-management.md

342da57

ran-huang added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 21, 2022

qiancai reviewed Mar 22, 2022

View reviewed changes

sql-plan-management.md Outdated Show resolved Hide resolved

Update sql-plan-management.md

28627d7

Co-authored-by: Grace Cai <qqzczy@126.com>

qiancai approved these changes Mar 22, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022

ti-chi-bot merged commit 52549ef into pingcap:master Mar 22, 2022

shichun-0415 mentioned this pull request Mar 28, 2022

update SPM doc for SQL plan auto capture pingcap/docs#7975

Merged

16 tasks

shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 28, 2022

This was referenced Apr 1, 2022

update SPM doc for SQL plan auto capture (#7975) pingcap/docs#8037

Closed

update SPM doc for SQL plan auto capture (#7975) pingcap/docs#8054

Closed

update SPM doc for SQL plan auto capture (#7975) pingcap/docs#8055

Merged

	该语句可以在 GLOBAL 作用域内变更指定的执行计划绑定的状态，作用域不可指定，默认作用域为 GLOBAL。
	该语句可以在 GLOBAL 作用域内变更指定执行计划绑定的状态为 `Enabled` 或者 `Disabled`，作用域默认为 GLOBAL，不可指定。

update SPM doc for SQL plan auto capture #8619

update SPM doc for SQL plan auto capture #8619

Uh oh!

Conversation

Reminiscent commented Mar 10, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reminiscent commented Mar 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shichun-0415 Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qiancai Mar 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reminiscent commented Mar 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qiancai left a comment

Choose a reason for hiding this comment

Uh oh!

shichun-0415 commented Mar 22, 2022

Uh oh!

ti-chi-bot commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ti-chi-bot commented Mar 10, 2022 •

edited

Loading