Skip to content

system-variables: update from generated source#8720

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
TomShawn:system-var-6.0
Mar 30, 2022
Merged

system-variables: update from generated source#8720
ti-chi-bot merged 7 commits into
pingcap:masterfrom
TomShawn:system-var-6.0

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Mar 22, 2022

What is changed, added or deleted? (Required)

system-variables: update from generated source

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn requested a review from ran-huang March 22, 2022 03:25
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2022
@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. area/general Relates to TiDB overview, architecture, and other general descriptions. v6.0 This PR/issue applies to TiDB v6.0. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. require-LGT1 Indicates that the PR requires an LGTM. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2022
@TomShawn TomShawn requested a review from en-jin19 March 23, 2022 02:06
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
en-jin19
en-jin19 reviewed Mar 29, 2022
View reviewed changes
Comment thread system-variables.md Outdated
en-jin19
en-jin19 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2022
@TomShawn @en-jin19
Update system-variables.md
e7193be 
Co-authored-by: Enwei <jinenwei@pingcap.com>
TomShawn
TomShawn commented Mar 30, 2022
View reviewed changes
Comment thread system-variables.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Mar 30, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 30, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 80f25ab

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2022
@ti-chi-bot ti-chi-bot merged commit 740008f into pingcap:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ran-huang ran-huang Awaiting requested review from ran-huang

1 more reviewer

@en-jin19 en-jin19 en-jin19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/general Relates to TiDB overview, architecture, and other general descriptions. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomShawn @ti-chi-bot @en-jin19