-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add doc for new-collation-enable in br #8809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/cc @3pointer @IANTHEREAL |
143272d to
f48114c
Compare
Signed-off-by: joccau <zak.zhao@pingcap.com>
f48114c to
493ca21
Compare
br/backup-and-restore-tool.md
Outdated
|
|
||
| 从 TiDB v6.0 版本开始,`new_collations_enabled_on_first_bootstrap` 配置的默认值由 `false` 改为 `true`,当上下游集群的此项配置相同时,才可以将上游集群的备份数据安全地恢复到下游集群中。 | ||
|
|
||
| 从 br v6.0 开始,br 会备份上游集群的 `new_collations_enabled_on_first_bootstrap` 配置项,同时在恢复时会检查此配置项是否与下游集群相同。如果用户需要将旧版本的备份数据恢复到 TiDB v6.0 中,用户需要自行检查上下游集群中的此配置项是否相同,若相同,则在恢复命令中添加 `--check-requirements=false` 可跳过此项配置检查。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果上下游的 new_collations_enabled_on_first_bootstrap 配置项不相同会怎样呢?会有什么报错呢?
Signed-off-by: joccau <zak.zhao@pingcap.com>
3pointer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
e9965ac to
3246b18
Compare
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 3246b18 |
|
In response to a cherrypick label: new pull request created: #8815. |
Signed-off-by: joccau zak.zhao@pingcap.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add comments for 6.0 br compatibility because of the default changing of the config
new_collations_enabled_on_first_bootstrapfromfalsetotrue.Which TiDB version(s) do your changes apply to? (Required)
6.0
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?