Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

zh: update TOC and error-handling.md#111

Merged
toutdesuite merged 10 commits into
masterfrom
xiang/minor-update
Jun 22, 2020
Merged

zh: update TOC and error-handling.md#111
toutdesuite merged 10 commits into
masterfrom
xiang/minor-update

Conversation

@WangXiangUSTC
Copy link
Copy Markdown
Contributor

@WangXiangUSTC WangXiangUSTC commented Jun 15, 2020

What is changed, added or deleted? (Required)

  1. mv dm-portal to config
  2. add error handling about load, similar with tools: some minor update docs-cn#3655, https://github.com/pingcap/docs-cn/blob/532f7458f6668da6bfd536132550d0ec7ea708b8/load-misuse-handling.md this file will be deleted, so move the content to dm's error-handling.md
  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

@WangXiangUSTC WangXiangUSTC added the status/PTAL This PR is ready for reviewing. label Jun 15, 2020
@github-actions github-actions Bot added the translation/welcome Waits for a contributor to translate this PR to docs-dm/zh or docs-dm/en. label Jun 15, 2020
@WangXiangUSTC WangXiangUSTC requested a review from csuzhangxc June 15, 2020 08:19
Comment thread zh/error-handling.md Outdated
Comment thread zh/error-handling.md
@yikeke yikeke requested a review from toutdesuite June 15, 2020 08:31
Comment thread zh/error-handling.md Outdated
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
Copy link
Copy Markdown
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@csuzhangxc, @toutdesuite, PTAL.

@toutdesuite toutdesuite changed the title zh: minor update on toc and error-handling zh: update TOC and error-handling.md Jun 17, 2020
Comment thread zh/error-handling.md Outdated

### load 处理单元报错 `packet for query is too large. Try adjusting the 'max_allowed_packet' variable`

#### 原因
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议与之前的格式保持一致,统一加 heading,或统一不加

Comment thread zh/error-handling.md Outdated

* MySQL client 和 MySQL/TiDB Server 都有 `max_allowed_packet` 配额的限制,如果在使用过程中违反其中任何一个 `max_allowed_packet` 配额,客户端程序就会收到对应的报错。目前最新版本的 DM 和 TiDB Server 的默认 `max_allowed_packet` 配额都为 `64M`。

* DM 的全量数据导入处理模块不支持对 dump sqls 文件进行切分,原因是 DM 的 dump 处理单元采用了最简单的编码实现,,如果在 DM 实现文件切分,那么需要在 `TiDB parser` 基础上实现一个完备的解析器才能正确的处理数据切分,但是随之会带来以下的问题:
Copy link
Copy Markdown
Contributor

@toutdesuite toutdesuite Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* DM 的全量数据导入处理模块不支持对 dump sqls 文件进行切分,原因是 DM 的 dump 处理单元采用了最简单的编码实现,如果在 DM 实现文件切分,那么需要在 `TiDB parser` 基础上实现一个完备的解析器才能正确的处理数据切分但是随之会带来以下的问题:
* DM 的全量数据导入处理模块不支持对 dump 处理模块导出的 SQL 文件进行切分。因为 DM 的 dump 处理单元采用了最简单的编码实现,如果在 DM 实现文件切分,需要在 `TiDB Parser` 基础上实现一个完备的解析器才能正确的处理数据切分但是随之会带来以下的问题:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dump sqls 是指 dump 处理单元导出的 sql 文件,要不改成这样:

DM 的全量数据导入处理模块不支持对 dump 处理模块导出的 SQL 文件进行切分。因为 DM 的 dump 处理单元采用了最简单的编码实现,如果在 DM 实现文件切分,需要在 `TiDB Parser` 基础上实现一个完备的解析器才能正确的处理数据切分。但是随之会带来以下的问题:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated~

Comment thread zh/error-handling.md Outdated
Comment thread zh/error-handling.md Outdated
Comment thread zh/error-handling.md Outdated
Comment thread zh/error-handling.md Outdated
Comment thread zh/error-handling.md Outdated
WangXiangUSTC and others added 4 commits June 18, 2020 10:48
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

@csuzhangxc, @toutdesuite, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

@csuzhangxc, @toutdesuite, PTAL.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 22, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@toutdesuite toutdesuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toutdesuite toutdesuite merged commit 1eec6f6 into master Jun 22, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/minor-update branch June 23, 2020 02:22
@toutdesuite toutdesuite mentioned this pull request Jul 24, 2020
2 tasks
@toutdesuite toutdesuite added translation/done This PR has been translated. and removed translation/welcome Waits for a contributor to translate this PR to docs-dm/zh or docs-dm/en. labels Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status/PTAL This PR is ready for reviewing. translation/done This PR has been translated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants